feat: keep track of document state in UI #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6fa093:
|
Codecov Report
@@ Coverage Diff @@
## userEvent14 #747 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 50 54 +4
Lines 965 1048 +83
Branches 389 413 +24
=============================================
+ Hits 965 1048 +83
Continue to review full report at Codecov.
|
ph-fritsche
added a commit
that referenced
this pull request
Oct 20, 2021
* feat: keep track of document state in UI * programmatically changing value resets UIValue * prevent stacking of value interceptors * programmatically changing value resets initial value * fix istanbul ignore see kentcdodds/kcd-scripts#218 * ignore uncovered `activeElement` being `null` * intercept calls to `setSelectionRange` * fix istanbul ignore see kentcdodds/kcd-scripts#218 * ignore omitting unnecessary event * remove obsolete util * move modules * fix istanbul ignore see kentcdodds/kcd-scripts#218 * ignore omitting unnecessary event
ph-fritsche
added a commit
that referenced
this pull request
Oct 21, 2021
* feat: keep track of document state in UI * programmatically changing value resets UIValue * prevent stacking of value interceptors * programmatically changing value resets initial value * fix istanbul ignore see kentcdodds/kcd-scripts#218 * ignore uncovered `activeElement` being `null` * intercept calls to `setSelectionRange` * fix istanbul ignore see kentcdodds/kcd-scripts#218 * ignore omitting unnecessary event * remove obsolete util * move modules * fix istanbul ignore see kentcdodds/kcd-scripts#218 * ignore omitting unnecessary event
ph-fritsche
added a commit
that referenced
this pull request
Nov 28, 2021
* programmatically changing value resets UIValue * prevent stacking of value interceptors * programmatically changing value resets initial value * intercept calls to `setSelectionRange`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Centralize workarounds for document state in UI diverging from the document state available per API.
Why:
Closes #744
How:
Combine previous workarounds in one place.
Apply workaround per
focusandblurevents.Intercept programmatically set values by event handlers and keep track of own manipulations of displayed values that might not translate to an equal
valueproperty.Intercept calls to
setSelectionRangeand keep track of selections in UI diverging from theselectionStart/selectionEndproperties.Checklist: