fix: input maxlength constraint should respect selection #1254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
For a text input / textarea that has maxlength, when the value reachs the maxlength limit, and the value is selected, new text should still be inserted. Becase the new text will replace the selected text.
The old code did not take the selection into consideration, causing new text not inserted.
Why:
To match how browsers behave
How:
When calulate the space remaining for maxlength, add the selected range length to the space.
Checklist: