Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CleanUp for toBeInTheDom and toHaveTextContent #45

Closed
antsmartian opened this issue Apr 6, 2018 · 6 comments
Closed

CleanUp for toBeInTheDom and toHaveTextContent #45

antsmartian opened this issue Apr 6, 2018 · 6 comments

Comments

@antsmartian
Copy link
Collaborator

antsmartian commented Apr 6, 2018 •
edited
Loading

Following up the conversation on #44, looks like we need to do bit of clean up on toBeInTheDom and toHaveTextContent on the jest extensions. I can pick this up and finish this task.

@gnapse Let me know if you have already picked this up.
@antsmartian antsmartian self-assigned this Apr 6, 2018
@gnapse
Copy link
Member

gnapse commented Apr 6, 2018

I started this in #46, and only after that I saw this.

@gnapse gnapse mentioned this issue Apr 6, 2018
Closed
6 tasks
@antsmartian antsmartian removed their assignment Apr 6, 2018
@antsmartian
Copy link
Collaborator Author

Alright, @gnapse this should be given to this library now : https://github.com/kentcdodds/dom-testing-library :) :)

@kentcdodds Thats a very cool move. In fact I was thinking, how we could decouple the library, so that one can reuse the DOM queries alone and exactly you had done this! This is awesome.. Cheers! 💯

@kentcdodds
Copy link
Member

Thanks! Sorry it means that y'all's PRs need to be moved over to the other package. Hopefully it should be pretty straightforward though.

@antsmartian
Copy link
Collaborator Author

@kentcdodds No problem, will move them.. Let us know once you completely decouple the codebase and done with your work.

@kentcdodds
Copy link
Member

I'm finished actually. react-testing-library has already been updated!

I'm hanging out with the family this weekend so I may not get to your PRs right away.

@antsmartian
Copy link
Collaborator Author

Perfect, will give the PR over there in sometime!

julienw pushed a commit to julienw/react-testing-library that referenced this issue Dec 20, 2018
@npeterkamps
feat(logging): don't log DOM in Cypress, don't highlight in the brows…
fd0c18c 
…er (testing-library#45)

* fix: don't crash when jsdom's document is passed to prettyDOM.

* feat(logging): don't log DOM in Cypress, don't highlight in the browser.

- added test to check whether Cypress doesn't log DOM
- ignore .idea folder (JetBrains IDE's)
- added myself to contributors

* fix: `.control` support landed in jsdom, updated istanbul ignore comments for improved coverage.

* Updated error message code style. Updated istanbul ignore.

* Improved error handling code style.

* Updated environment check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor custom matchers (closes #45)
3 participants
@gnapse @antsmartian @kentcdodds