engines config breaks deploys to Netlify

[wKovacs64]

• react-testing-library version: 1.4.0
• node version: 6.13.1
• npm (or yarn) version: yarn 0.18.1

Relevant code or config:

react-testing-library package.json:

"engines": {
  "node": ">=8",
  "npm": ">=5"
},

What you did:

• deployed existing site to Netlify after adding react-testing-library to devDependencies

What happened:

• Netlify deploy failed:

7:57:52 PM: error [email protected]: The engine "node" is incompatible with this module. Expected version ">=8".
7:57:52 PM: error Found incompatible module

Problem description:

• react-testing-library uses a somewhat restrictive engines stanza in package.json

Suggested solution:

• relax the Node version requirement for react-testing-library to 4.5 (from kcd-scripts babel config) or at least 6 (active LTS)?

[kentcdodds]

I'd be fine with 6. But why don't you upgrade to 8?

[wKovacs64]

In this particular case, I could, as Netlify provides a way to do that and I don't care about the Node version for my app. But I'd imagine scenarios exist where that's not possible, either due to lack of control of the runtime environment or app-specific target requirements or what-have-you. It seems like an odd and unexpected developer experience to require runtime environment changes to use such a small testing library when there's no underlying technical reason for it.

6 makes sense, I'll send a PR for it. Thanks!

[wKovacs64]

Oh. Just noticed kcd-scripts uses Object.entries. Thoughts? Maybe this truly does require Node 8.

[kentcdodds]

kcd-scripts shouldn't make any difference for whether you can use this library. This library doesn't depend on kcd-scripts (except as a dev dependency, which you shouldn't need to install). Now if you're using kcd-scripts yourself, then yes, you'll have to use Node 8. That will never support less than Node 8.

[wKovacs64]

Yeah, I was mistakenly trying to run your validate script in react-testing-library on Node 6. Sorry for the confusion, lack of sleep and running on fumes today. 😄