-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(no-await-sync-queries): add auto-fix #919
base: main
Are you sure you want to change the base?
feat(no-await-sync-queries): add auto-fix #919
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 96.23% 96.34% +0.10%
==========================================
Files 44 46 +2
Lines 2419 2489 +70
Branches 1000 1030 +30
==========================================
+ Hits 2328 2398 +70
Misses 91 91 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good but you're assuming there will always be a space after the await
which means await(getByIcon('search'))
will error.
I'm pretty sure you can fix this by just removing the space, since the fixer doesn't need to care about the styling of the output
@G-Rath Good catch and thanks for the review 🙂 Let me know what you think:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
d5cb9ee
to
afdd27a
Compare
afdd27a
to
6120e73
Compare
Checks
Changes
Do we want to remove the
async
from the test callback when there's no otherawait
s in it?Context
Fixes an item in #202