Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Checking Bun compatibility #1264

Closed
wants to merge 9 commits into from

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 16, 2023

Checking if the repo is compatible with Bun. There's on test assertion that needed changing and I'm pretty sure that's a bug in Bun.

I wonder if all the kcd-script calls actually use Bun since they have a shebang that wants Node.js. Type-checking shows only 10% difference:

$ hyperfine "npx kcd-scripts typecheck --
build types"
Benchmark 1: npx kcd-scripts typecheck --build types
  Time (mean ± σ):      2.384 s ±  0.049 s    [User: 4.826 s, System: 0.204 s]
  Range (min … max):    2.326 s …  2.493 s    10 runs
 
$ hyperfine "bunx kcd-scripts typecheck -
-build types"
Benchmark 1: bunx kcd-scripts typecheck --build types
  Time (mean ± σ):      2.191 s ±  0.082 s    [User: 4.552 s, System: 0.183 s]
  Range (min … max):    2.125 s …  2.401 s    10 runs

bun run format works locally but not in CI:

Run bun run format --check --no-write
$ kcd-scripts format --check --no-write
/usr/bin/bash: line [1](https://github.com/testing-library/dom-testing-library/actions/runs/6206581608/job/16850977595?pr=1264#step:4:1): kcd-scripts: command not found

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e93ef4:

Sandbox Source
react-testing-library-examples Configuration

@eps1lon
Copy link
Member Author

eps1lon commented Sep 16, 2023

All the CI steps work locally but not in CI. This is not something I wish to debug. But good to know we can potentially debug Bun compat issues locally.

@eps1lon eps1lon closed this Sep 16, 2023
@eps1lon eps1lon deleted the test/bun branch September 16, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant