chore: upgrade kcd-scripts dev dependency #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 74f2739:
|
Codecov Report
@@ Coverage Diff @@
## main #1134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 25 +1
Lines 989 985 -4
Branches 322 322
=========================================
- Hits 989 985 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Thanks but we landed this in #1208. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Update the dev dependency
kcd-scriptsWhy: To remain up-to-date with newer sub-dependencies
How: Update
kcd-scripts, fix various linting warnings usingeslint-disable-next-linewhere relevantChecklist:
docs site N/A
I was working on a project with an extremely similar codebase (literally based on this one) and found that the newer version of the
kcd-scriptsdependency was slightly tricky to update. I figured I'd submit an upstream PR to help avoid duplicative development time :)