-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust *ByValue to *ByDisplayValue #51
Conversation
These changes in typings were not done when changing the API from *ByValue to *ByDisplayValue Fixes #42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@all-contributors please add @ppi-buck for code |
I've put up a pull request to add @ppi-buck! 🎉 |
Let's try that again... |
@all-contributors please add @ppi-buck for code |
I've put up a pull request to add @ppi-buck! 🎉 |
lol, I just realized we've already added you 😂 |
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
🎉 This PR is included in version 4.0.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
These changes in typings were not done when changing the API from *ByValue to *ByDisplayValue
Fixes #42
What: Change typings to resemble newer *ByDisplayValue API
Why: API introduced breaking changes that were not resembled in typings of this project
How: by changing the typings to match the correct function names
Checklist: