feat: allow cgroupns-mode and userns-mode to be configured #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dghilardi
force-pushed
the
feature/cgroupns-mode-userns-mode
branch
3 times, most recently
from
5010006 to
d2c79d6
Compare
DDtKey
reviewed
Apr 29, 2024
DDtKey
reviewed
Apr 29, 2024
dghilardi
force-pushed
the
feature/cgroupns-mode-userns-mode
branch
from
fbedebc to
27ecb9c
Compare
* Add setters and getters for cgroupns-mode in RunnableImage * Pass cgroupns_mode field to HostConfig during container start
* Add setters and getters for userns-mode in RunnableImage * Pass userns_mode field to HostConfig during container start
dghilardi
force-pushed
the
feature/cgroupns-mode-userns-mode
branch
from
27ecb9c to
38eac7b
Compare
DDtKey
approved these changes
Apr 30, 2024
|
Thank you! 🙏 |
Merged
DDtKey
pushed a commit
that referenced
this pull request
Apr 30, 2024
## 🤖 New release * `testcontainers`: 0.16.5 -> 0.16.6 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.16.6] - 2024-04-30 ### Details #### Features - Add `get_host` to `Container` and deprecate `get_host_ip_address` ([#618](#618)) - Allow cgroupns-mode and userns-mode to be configured ([#605](#605)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow cgroupns and userns to be defined when building RunnableImage