feat: add registry and owner parameters to Image
#550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to override name of the image. Thus, user will be able to change registry, owner and the name itself. Closes testcontainers#335
It's alternative solution for testcontainers#549 Adds ability to set registry and owner on per-Image basis, and override them with `RunnableImage`.
This was referenced Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's alternative solution for #549
A bit more user-friendly because operates with separate entities, but kinda redundant. Instead of configuring 1 parameter to override, users will have to split it to 3.
E.g:
gallery.ecr.aws/docker/library/redisshould be represented as:gallery.ecr.awsdocker/libraryredisBut user actually can just pass
gallery.ecr.aws/docker/library/redisto name, orgallery.ecr.aws/docker/libraryto owner. We can't protect it.Adds ability to set registry and owner on per-Image basis, and override them with
RunnableImage.Closes #335