Support registries other than Docker Hub #311
Conversation
Docker Hub has rate limits for container image requests which can be a bottleneck in test environments. For such cases, it is better to rely on alternative registries.
There can be errors like timeouts and rate limits when `docker run` command is exectued. Hence, in addition to panicking with generic message, stderr output from the child process can be informative for debugging purposes.
There was a problem hiding this comment.
Thanks!
As far as I know, the registry is part of the container identifier with Docker Hub simply being the default.
Shouldn't we implement this as a default fn on the trait then where each image can define, which registry it is located at?
Some registries might be mirrors but not every registry serves every image.
Ideally, all images would define their identifiers as fully-qualified. Hence, if an image is located at a different registry, you can already use that image by just specifying its registry as part of the identifier.
Do I understand you correctly that you want to override, what the default registry is? Is there a way of doing this in the CLI without changing the image identifier? Should probably be a setting on Cli then!
|
Fwiw, the go library matches this patch rather than putting it in the CLI...you can pass a full image name, which can have the registry pretended and it will parse it and behave correctly. |
|
Closing as outdated, but this is gonna be supported soon. Thanks! |
Hey @thomaseizinger !
We think this would be super helpful for our use cases. Lemme know WDYT. Have added more info in the commit messages.