Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce async docker interface and shiplift-backed implementation #268

Merged
merged 6 commits into from
Feb 19, 2021
Merged

Introduce async docker interface and shiplift-backed implementation #268

merged 6 commits into from
Feb 19, 2021

Conversation

thomaseizinger
Copy link
Collaborator

@thomaseizinger thomaseizinger commented Feb 18, 2021 •
edited
Loading

Blocked by:

@thomaseizinger thomaseizinger mentioned this pull request Feb 18, 2021
Closed
7 tasks
@thomaseizinger thomaseizinger force-pushed the async-docker-shiplift branch 2 times, most recently from 2b571ae to ec3e8e8 Compare February 18, 2021 07:19
thomaseizinger
thomaseizinger commented Feb 18, 2021
View reviewed changes
src/clients/http.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/clients/http.rs Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger commented Feb 18, 2021
View reviewed changes
src/core/logs.rs Show resolved Hide resolved
src/clients/http.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger force-pushed the async-docker-shiplift branch 3 times, most recently from d8aa515 to 33b71b9 Compare February 19, 2021 05:25
@thomaseizinger
Add test for starting containers in parallel
9f2aa34
@thomaseizinger
Make Docker trait pub(crate)
590dbc0 
To make this possible, we define the two `run` functions on the client
directly instead of enforcing it through an interface.

This allows us to make `Container` depend on a trait object instead
of using a type parameter. This simplifies the API and at the same
time allows us to shrink the public API of the crate, which reduces
breaking changes in the future.
@thomaseizinger
Remove Logs struct and WaitForMessage in favor of LogStream
8b66bf8 
This is the same pattern as we use for the async client which further
decreases the public API of the crate.
@thomaseizinger
Unify port parsing between Cli and Http client
a0c924e
@thomaseizinger thomaseizinger marked this pull request as ready for review February 19, 2021 06:08
@thomaseizinger
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 19, 2021

Build succeeded:

@bors bors bot merged commit 5934584 into dev Feb 19, 2021
@thomaseizinger thomaseizinger mentioned this pull request Feb 19, 2021
Closed
@DDtKey DDtKey deleted the async-docker-shiplift branch April 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @ywalterh