fix: correct drop of a network for sync container (#612)

Network must be dropped only after container, not before
testcontainers · Apr 29, 2024 · 95f67ec · 95f67ec
1 parent b4d1624
commit 95f67ec
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/testcontainers/src/core/containers/async_container.rs b/testcontainers/src/core/containers/async_container.rs
@@ -33,8 +33,7 @@ pub struct ContainerAsync<I: Image> {
     id: String,
     image: RunnableImage<I>,
     pub(super) docker_client: Arc<Client>,
-    #[cfg_attr(not(feature = "blocking"), allow(dead_code))]
-    pub(super) network: Option<Arc<Network>>,
+    network: Option<Arc<Network>>,
     dropped: bool,
 }
 

diff --git a/testcontainers/src/core/containers/sync_container.rs b/testcontainers/src/core/containers/sync_container.rs
@@ -160,7 +160,6 @@ impl<I: Image> Drop for Container<I> {
     fn drop(&mut self) {
         if let Some(mut active) = self.inner.take() {
             active.runtime.block_on(async {
-                drop(active.async_impl.network.take());
                 match active.async_impl.docker_client.config.command() {
                     env::Command::Remove => active.async_impl.rm().await,
                     env::Command::Keep => {}