Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: made sure that cargo-hack runs testcases with the --locked option #181

Closed

Conversation

CommanderStorm
Copy link
Contributor

@CommanderStorm CommanderStorm commented Aug 19, 2024

This PR is basically #180 (comment), but possibly less work for you to accept/reject.

Hope this helps ^^

(also includes the fix for the mongo-example from #178)

@DDtKey
Copy link
Contributor

DDtKey commented Aug 20, 2024

Libraries don't usually have Cargo.lock commited. Thus, it doesn't help here
It's important, because users of crate may have different versions in their lock files and we expect testcontainers to work with latest ones

@CommanderStorm CommanderStorm deleted the locked-cargo-hack branch August 20, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants