Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codestyle): switch to ruff from black for code formatting #529

Conversation

max-pfeiffer
Copy link
Contributor

Changed pre-commit config. Some files
became re-formatted.

Changed pre-commit config. Some files
became re-formatted.
@santi santi changed the title feat: switched to Ruff for code formatting feat(codestyle): switched to Ruff for code formatting Apr 5, 2024
Copy link
Collaborator

@santi santi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Always nice with fewer dependencies and tools for development setups. 🎉

I am all for merging this, but I think @totallyzen also should have a look as he is the one that set this up in the first place.

@santi santi requested a review from totallyzen April 5, 2024 09:43
@santi santi changed the title feat(codestyle): switched to Ruff for code formatting fix(codestyle): switched to Ruff for code formatting Apr 5, 2024
@totallyzen totallyzen changed the title fix(codestyle): switched to Ruff for code formatting chore(codestyle): switch to ruff from black for code formatting Apr 5, 2024
Copy link
Collaborator

@totallyzen totallyzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I changed the title to chore(): ... because this only impacts readability and I don't think we need it on the changelogs

@totallyzen
Copy link
Collaborator

he is the one that set this up in the first place

I like writing clean code, but sometimes copy/pasta is the way to go for productivity so I'm not immune either. 😂

@totallyzen totallyzen merged commit 9a89748 into testcontainers:main Apr 5, 2024
39 checks passed
mloesch pushed a commit to mloesch/testcontainers-python that referenced this pull request Apr 8, 2024
…estcontainers#529)

Changed pre-commit config. Some files became re-formatted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants