Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the GCP PubSub container work #209

Closed
wants to merge 4 commits into from

Conversation

hy9be
Copy link

@hy9be hy9be commented Apr 24, 2022

Accidentally closed the PR under review #183 and cannot reopen it. Recreated this one.

Changes

@hy9be hy9be changed the title Fix gcp pubsub Make the GCP pubsub container work Apr 24, 2022
@hy9be hy9be changed the title Make the GCP pubsub container work Make the GCP PubSub container work Apr 24, 2022
@tillahoffmann
Copy link
Collaborator

tillahoffmann commented Apr 27, 2022

Thanks for the updated PR! It looks like it is reverting a number of changes introduced in previous work, e.g the docker version from #203 or clickhouse support from #173. This may be the result of copying code from an outdated branch. That's also the reason for early test failures.

@hy9be
Copy link
Author

hy9be commented Apr 27, 2022

Yeah, I think you are right. I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants