Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: tests are run inconsistently in CI pipeline #482

Closed
max-pfeiffer opened this issue Mar 15, 2024 · 2 comments · Fixed by #497
Closed

Bug: tests are run inconsistently in CI pipeline #482

max-pfeiffer opened this issue Mar 15, 2024 · 2 comments · Fixed by #497

Comments

@max-pfeiffer
Copy link
Contributor

max-pfeiffer commented Mar 15, 2024

Describe the bug

Maybe not a real bug but more an issue I came across when I looked at how our tests are run in CI pipeline:

So looking at pyproject.toml I guess we want to support Python versions from 3.9 - 4.0, so our pipeline needs to reflect this.

I also see that we do not pin the versions of our Ubuntu runners. I would say it's a better practice to pin version to get predictable CI results.

Also I am scratching my head what purpose that make file still serves there. I see no need to use it in the pipeline jobs.

Also we use coverage, but are not doing anything with that test coverage data.

I could spend some time fixing this up. But I would be very grateful for some feedback and thoughts. Not so sure if I miss something here.

@totallyzen
Copy link
Collaborator

hey @max-pfeiffer thanks for the insights!

Personal note: I monitor the testcontainers slack more often than the issues, don't have the time to monitor both, sorry about that - please do come and discuss on slack, (you can also raise the issue here, but it may take me and others longer to act)

Back to your issue:

  • community modules
    • maybe you are right, should remove the python-version from that and hard-code it on 3.11
    • since we only write pure python in here, it's probably a better matrix option to change runners
    • the multi-arch runners has been on my mind but zero energy to do anything with it
  • makefile

@max-pfeiffer
Copy link
Contributor Author

@totallyzen Ok, so I will create a PR addressing these inconsistency issues and pin runner versions.

I just went through #460 and left some comments and suggestions.

I haven't used slack in ages. But I will check on that channel now.

alexanderankin pushed a commit that referenced this issue Mar 30, 2024
- Fixed inconsistencies for community module test runs: using all
supported Python versions
- Pinned runner version (best practice)

fixes #482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants