Skip to content

Commit

Permalink
Merge pull request #153 from ebyhr/ebi/fix-oracle
Browse files Browse the repository at this point in the history
Add missing _configure to OracleDbContainer
  • Loading branch information
yakimka authored Mar 26, 2022
2 parents 2903327 + 6b54619 commit 6641b25
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion testcontainers/oracle.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class OracleDbContainer(DbContainer):
-------
::
with OracleDbContainer():
with OracleDbContainer() as oracle:
e = sqlalchemy.create_engine(oracle.get_connection_url())
result = e.execute("select 1 from dual")
"""
Expand All @@ -24,3 +24,6 @@ def get_connection_url(self):
dialect="oracle", username="system", password="oracle", port=self.container_port,
db_name="xe"
)

def _configure(self):
pass

0 comments on commit 6641b25

Please sign in to comment.