Skip to content

Commit

Permalink
Merge branch 'main' into with_env_file
Browse files Browse the repository at this point in the history
  • Loading branch information
Tranquility2 authored Nov 16, 2024
2 parents ae3d162 + f1d8d35 commit 3f5f902
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ You need to have the following tools available to you:

## Adding new containers

We have an [issue template](.github/ISSUE_TEMPLATE/new-container.md) for adding new containers, please refer to that for more information.
We have an [issue template](./ISSUE_TEMPLATE/new-container.md) for adding new containers, please refer to that for more information.
Once you've talked to the maintainers (we do our best to reply!) then you can proceed with contributing the new container.

> [!WARNING]
Expand Down
3 changes: 2 additions & 1 deletion modules/vault/testcontainers/vault/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# under the License.

from http.client import HTTPException
from urllib.error import URLError
from urllib.request import urlopen

from testcontainers.core.container import DockerContainer
Expand Down Expand Up @@ -61,7 +62,7 @@ def get_connection_url(self) -> str:
exposed_port = self.get_exposed_port(self.port)
return f"http://{host_ip}:{exposed_port}"

@wait_container_is_ready(HTTPException)
@wait_container_is_ready(HTTPException, URLError)
def _healthcheck(self) -> None:
url = f"{self.get_connection_url()}/v1/sys/health"
with urlopen(url) as res:
Expand Down

0 comments on commit 3f5f902

Please sign in to comment.