Add stdout and stderr fields to container exec result
#874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/testcontainers/src/container-runtime/clients/container/container-client.ts
Show resolved
Hide resolved
cristianrgreco
added
enhancement
packages/testcontainers/src/container-runtime/clients/container/podman-container-client.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/container-runtime/clients/container/docker-container-client.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/generic-container/abstract-started-container.ts
Outdated
Show resolved
Hide resolved
cristianrgreco
approved these changes
Nov 25, 2024
|
@chungjung-d Pls run an |
cristianrgreco
changed the title
stdout and stderr fields to container exec result
|
Thanks @chungjung-d ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stderr output for exec function on issue #842
I chose not to add an outputMode option to the existing exec function because it would compromise the integrity of the current ExecResult type. Instead, I implemented a new execVerbose function to provide separate handling and output for stdout and stderr.