Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nats): added js and support arg without value #873

Closed
wants to merge 3 commits into from
Closed

feat(nats): added js and support arg without value #873

wants to merge 3 commits into from

Conversation

Naymi
Copy link

@Naymi Naymi commented Nov 24, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 24, 2024 •
edited
Loading

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 4059cb9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67433d723f2e7100085b3045
😎 Deploy Preview https://deploy-preview-873--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cristianrgreco
cristianrgreco reviewed Nov 24, 2024
View reviewed changes
packages/modules/nats/src/nats-container.test.ts
// JetStream {
it("should start with JetStream ", async () => {
// enable JS
const container = await new NatsContainer().withJS().start();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is JS a well known acronym for Jetstream for Nats users?

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Nov 24, 2024
@jonjomckay
Copy link
Contributor

This would be helpful for us - we use JetStream, but we're unable to use NatsContainer at all at the moment, as we can't use withArg with a single parameter.

@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Nov 28, 2024 •
edited
Loading

Hi @jonjomckay, I'm not familiar with NATS. If you were using the NatsContainer and came across a method withJS, would you understand that it is for enabling jetstream, or would withJetStream be better?

@jonjomckay
Copy link
Contributor

@cristianrgreco withJetStream would be clearer to me. JS is probably a bit confusing, especially with this being a JavaScript library!

@cristianrgreco
Copy link
Collaborator

IDK if @Naymi is going to address the issues with the PR, but @jonjomckay if you want this feature then I'd happily accept a PR. A copy of this one is fine with withJS changed to withJetStream, with lint issues addressed.

@jonjomckay jonjomckay mentioned this pull request Nov 29, 2024
Merged
@jonjomckay
Copy link
Contributor

@cristianrgreco @Naymi I've opened up another PR with the linting and naming fixed: #877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianrgreco cristianrgreco cristianrgreco left review comments

Assignees
No one assigned
Labels
enhancement New feature or request minor Backward compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naymi @jonjomckay @cristianrgreco