-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add K3s module #864
Add K3s module #864
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @joebowbeer! Do you mind making this PR a draft if it's not ready for review/merge? That way I'll know when it's ready and can have a look |
@cristianrgreco This is now ready for review. |
5a669f2
to
7b0fb8e
Compare
Signed-off-by: Joe Bowbeer <[email protected]>
7b0fb8e
to
c4d7f5d
Compare
The failure is unrelated to my changes?
|
@cristianrgreco See details and questions below. Passing tests:
Failing tests:
I suspect it is the rootless podman that is preventing k3s from running, as k3s runs According to limitations listed in the Java docs https://java.testcontainers.org/modules/k3s/#known-limitations
Thoughts? |
If k3s doesn't support running rootlessly then we'll have to disable the Podman tests for it. Perhaps something like https://github.com/testcontainers/testcontainers-node/blob/main/packages/testcontainers/src/generic-container/generic-container-dockerfile.test.ts#L60. I'd also update the module docs |
@cristianrgreco I made the following changes:
The tests pass for me on macOS w/AppleSilicon using both Rancher Desktop and Podman (rootful). |
FYI - Leaving a bread crumb in case From k3s-io/k3s#4873 (comment)
|
@joebowbeer If you think there's an issue with the module, then a PR is welcome |
Understood. I'm not aware of an issue at the moment; only a diff between the implementations (Golang vs. all others) that I'm hoping to understand, eventually. |
Adds K3s module. Fixes #863
Notes:
@types/dockerode
is missing a HostConfig field. I created a discussion at DTtar-stream@3
. This version is currently hoisted to the top-level in the package-lock, but its position may be tenuous.