Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Docker registry passwords that contain a colon #839

Merged

Conversation

joshystuart
Copy link
Contributor

Fixes #838

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 1201c7b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/66fccb7d5160330008486626
😎 Deploy Preview https://deploy-preview-839--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshystuart
Copy link
Contributor Author

This was a problem in the java version too, but was resolved some time ago: testcontainers/testcontainers-java#1492

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Oct 2, 2024
@cristianrgreco cristianrgreco changed the title Fixes docker auth passwords that contain a colon Fix for Docker registry passwords that contain a colon Oct 2, 2024
@cristianrgreco cristianrgreco merged commit 50df1d4 into testcontainers:main Oct 3, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Backward compatible bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A docker auth password that contains a colon truncates the password
2 participants