Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MongoDB docs about directConnection #821

Merged

Conversation

BradLewis
Copy link
Contributor

When playing around with the mongodb testcontainers today, we ran into an issue where the tests were unable to connect to the mongodb database. After a bit of debugging, we found that this was due to directConnection not being set to true.

This PR is simply to update the documentation to make it explicit that you will need to set directionConnection: true either as an option when connecting, or directly as part of the connection string.

Addresses #697

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit cd9678d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/66c3d77f0294ed000864f5a8
😎 Deploy Preview https://deploy-preview-821--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ica set and that you need to set directConnection to be true
@cristianrgreco cristianrgreco added patch Backward compatible bug fix documentation Changes to documentation labels Aug 22, 2024
@cristianrgreco
Copy link
Collaborator

Love it, thanks @BradLewis

@cristianrgreco cristianrgreco changed the title Update the mongodb documentation Update MongoDB docs about directConnection Aug 22, 2024
@cristianrgreco cristianrgreco merged commit 6e1213b into testcontainers:main Aug 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to documentation patch Backward compatible bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants