-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct testcontainers for use with latest MySQL 8.3 version #8131
Changes from 3 commits
12bf2f6
b936ec0
a9d2270
9b47a80
2ea7fb5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
redis: | ||
image: redis | ||
db: | ||
image: mysql:5.7.34 | ||
image: mysql:8.0.36 | ||
environment: | ||
MYSQL_RANDOM_ROOT_PASSWORD: "true" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ public class MySQLContainer<SELF extends MySQLContainer<SELF>> extends JdbcDatab | |
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("mysql"); | ||
|
||
@Deprecated | ||
public static final String DEFAULT_TAG = "5.7.34"; | ||
public static final String DEFAULT_TAG = "5.7.44"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any issue is we keep 5.7.34 as a default? I would like to avoid breaking existing test that relies on default constructor. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see why a patch/bugfix release would be expected to break things for people and if you check the history it was previously changed to a new patch releases. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For what it's worth here's an example: |
||
|
||
@Deprecated | ||
public static final String IMAGE = DEFAULT_IMAGE_NAME.getUnversionedPart(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any issue is we keep 10.3.6 as a default? I would like to avoid breaking existing test that relies on default constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes in fact, because 10.3.6 does not have ARM image variants and crashes when you try to run on Colima under emulation as noted in #8131 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.3.39 with multiple archs: https://hub.docker.com/layers/library/mariadb/10.3.39/images/sha256-a4b57b620852e26f2c306c79fd8a61e22c7cd6e55d0a55d5521854ed2c370102?context=explore
10.3.6 with only amd64
https://hub.docker.com/layers/library/mariadb/10.3.6/images/sha256-ab3aab60f76b6d2d2e2d9d2c486029b63ad7cc9517ad4567a27c66999f8a23ce?context=explore