-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jcenter from list of repositories #3755
Conversation
Note that this is not the only dependency on jcenter/bintray in testcontainers. As far as I understand, testcontainers currently publishes its releases via bintray: https://github.com/testcontainers/testcontainers-java/blob/master/gradle/bintray.gradle |
@gastaldi could you please remove it from everywhere, not only the top level file? There are a few entries (e.g. examples) |
@bsideup My Gradle-fu is a bit limited, but I think I removed every reference from the repository, except for the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
@@ -2,7 +2,6 @@ plugins { | |||
id 'io.franzbecker.gradle-lombok' version '3.1.0' | |||
id 'nebula.provided-base' version '3.0.3' | |||
id 'com.github.johnrengelman.shadow' version '5.2.0' | |||
id "com.jfrog.bintray" version "1.8.4" apply false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not quite as easy as this; we need to replace our bintray publication with something else, and I'm afraid that this is a task that core maintainers need to do.
Removal of jcenter()
from repositories
blocks is still valuable, though!
Seems to be superseeded by #4931, sorry! Thanks for your time working on this PR tho, much appreciated! |
See https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ for more details