Update oracle wait strategy for Healthcheck

[KyleAure]

Wait until DATABASE IS READY TO USE! is shown in the logs before starting.
Wait until container healthcheck reports healthy
Fixes #1292

[kiview]

You said in #1292 that the official Dockerfile even provides a health check, so I think using the Testcontainers health check wait strategy would even be nicer and ideally more future proof, especially considering slightly altered user images.

[rnorth]

If we can be confident that the images include healthchecks, then yes I think this would be a good idea.

[kiview]

Yes positive:
https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/dockerfiles/18.4.0/Dockerfile.xe#L80

[KyleAure]

Updated for healthcheck and tested locally. Though, I'd be hesitant to merge this until we have proper tests setup.

[kiview]

Thanks, LGTM like this.
Regarding the merging, let me create a meta-issue to track to open breaking changes to Oracle module and we try to get them in in a single breaking release.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

[kiview]

Adding OEM_EXPRESS_PORT is not really necessary for this PR, isn't it?

[kiview]

Ok, maybe I messed something up during merging, but currently, the tests fail. Will have to investigate this further.

[KyleAure]

@kiview @OnnoHuijgen I believe this PR is no longer needed. This was being proposed before the gvenzl/oracle-xe image was released and we were still being forced to build our own images based on Oracle's documented process.
The gvenzl/oracle-xe does not ship with a healthcheck enabled by default. So I think continuing to use the LogMessageWaitStrategy setup in pull #4402 should be the strategy going forward.

[kiview]

Cool, thanks a lot for clarifying this @KyleAure (and in general for being up to date regarding this module, much appreciated).
I know that @gvenzl did plan to add a healthcheck to the image, but since this is a Docker-specific feature and not OCI compliant, there were some challenges involved regarding how the image is built.

You can find some more context here:
opencontainers/image-spec#749 (comment)