Handle large files with copyFileToContainer #2864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/master/handle-large-files-with-copyfiletocontainer-c97ba6
branch
from
56758bd to
46ff43b
Compare
bsideup
reviewed
Jun 13, 2020
|
|
||
| transferable.transferTo(tarArchive, containerPath); | ||
| tarArchive.finish(); | ||
| Path tarFile = Files.createTempFile("test-containers-copy-file-to-container", ".tar"); |
There was a problem hiding this comment.
Perhaps it is better to use PipedInputStream
There was a problem hiding this comment.
Docker Java creates a temp file anyway, so we are not winning much.
There was a problem hiding this comment.
that is something I am willing to fix in docker-java as well :)
There was a problem hiding this comment.
Shall we change this here now, so that we can avoid temp file creation altogether once docker-java is changed?
|
I switched to use binds for large files and copy for configuration files, so I do not need the change. |
findepi
deleted the
findepi/master/handle-large-files-with-copyfiletocontainer-c97ba6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2863