-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure in Oracle/SQL Server modules due to useSSL query param #568
Comments
* Bump POMs and Changelogs for 1.6.0 release * Disable `useSSL` query param for Oracle/SQL Server modules Temporary fix for testcontainers/testcontainers-java#568
* Bump POMs and Changelogs for 1.6.0 release * Disable `useSSL` query param for Oracle/SQL Server modules Temporary fix for testcontainers/testcontainers-java#568
Is it too late to revert #561. |
I can fix this in a week or so. Unless somebody wants to do it faster, @rnorth , can you assign this to me? |
I think GitHub only allows assigning to Members, but I think it would be nice if you fix this 🙂 |
Also note that argument separator in connectionString may differ some don't even use |
As the original problem was specific to MySQL I think I will rework my fix to be MySQL container specific. |
Add template method allowing JDBCContainer subclasses to have a specific form of JDBC URL used for establishing Connections. Fixes #568
I've made a quick PR to resolve this without a wholesale reversion - #569. Please could you take a look and let me know if it makes sense? |
After upgrading the Oracle and SQL Server modules to use 1.6.0 as their base, unfortunately we had some build failures. It seems that #561 has unfortunately led to JDBC URLs being created that Oracle and SQL Server consider invalid.
In order to progress the 1.6.0 release I'm going with an ugly but necessary workaround; overriding the
createConnection
method for these classes so thatappendDisableSslConfig
is not used.We can come up with a cleaner workaround, but for now this works and unblocks the 1.6.0 release for these modules.
This underscores the value of having a single repository with wider tests to guard against regression, as described in #564!
The text was updated successfully, but these errors were encountered: