-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negotiate client version for docker compose #432
Negotiate client version for docker compose #432
Conversation
@mdelapenya It looks like the failures are unrelated to my changes?
It seems to have failed to locate an image in test setup. |
@rahul-muttineni-okcupid could you please rebase with latest changes 🙏 ? We fixed the netlify integration errors in #434, so they should pass now. Let's also check if the image pull failed because of any glitch 🤞 |
4971078
to
23e1961
Compare
@mdelapenya It's looking good now, thanks! |
Codecov Report
@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 65.28% 65.13% -0.15%
==========================================
Files 19 19
Lines 1178 1179 +1
==========================================
- Hits 769 768 -1
- Misses 302 304 +2
Partials 107 107
Continue to review full report at Codecov.
|
@mdelapenya The next error is this (I'm seeing it on other open PRs too)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Even though client version negotiation has been implemented for vanilla docker here, it hasn't been implemented for Docker Compose. I ran into the issue while setting up some integration tests and negotiating the client version fixed the issue and allowed me to make progress.