-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read only bind and volume mounts #382
Conversation
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
==========================================
- Coverage 62.28% 62.20% -0.09%
==========================================
Files 15 15
Lines 1042 1045 +3
==========================================
+ Hits 649 650 +1
- Misses 291 292 +1
- Partials 102 103 +1
Continue to review full report at Codecov.
|
Thanks for this contribution, it makes total sense. I wonder whether directly merging it as a breaking change in next minor (we are still in 0.x.y) or include it in an eventual 1.0.0 release 🤔 @gianarb thoughts? |
I though about making it non breaking but less obvious - keeping the |
I would like to go with the |
be9cc2b
to
61cfbb6
Compare
Did it with |
Is anything else needed? |
Can you double check if there are incompatible changes with #386? |
I think #386 make this PR obsolete and it can be closed. |
Closed as per @silh's comment. Thanks you very much for your time with testcontainers-go! |
Added the ability to specify read-only bind and volume mounts.
That ability is present in docker client itself as well as in java version of testcontainers - see https://www.testcontainers.org/features/files/