Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix image label test #2689

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Aug 6, 2024

Fix test for image label setting which could fail if the volume already existed.

Fix test for image label setting which could fail if the volume already
existed.
@stevenh stevenh requested a review from a team as a code owner August 6, 2024 20:20
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 708d410
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66b28593d9d1b6000833cbd7
😎 Deploy Preview https://deploy-preview-2689--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Aug 7, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 7, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit ab3a0f5 into testcontainers:main Aug 7, 2024
112 checks passed
@stevenh stevenh deleted the test/image-label branch August 7, 2024 11:32
mdelapenya added a commit that referenced this pull request Aug 7, 2024
* main:
  fix: missing image build errors (#2651)
  test: fix image label test (#2689)
  chore(deps): bump github.com/docker/docker from 27.0.3+incompatible to 27.1.0+incompatible (#2682)
  chore: print Docker Info labels in banner (#2681)
  fix: incorrect parsing of exposedPorts in readiness check (#2658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants