feat(redpanda): Add option for arbitrary bootstrap config #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Jul 23, 2024
Absolutely. Thanks for the quick review @mdelapenya ! |
kiview
previously approved these changes
Jul 23, 2024
oleiman
force-pushed
the
redpanda-extra-config
branch
from
c69723c to
86985f0
Compare
|
force push contents: a test |
10 tasks
|
Hey @mdelapenya - does the test I added look ok to you? |
|
Ping @mdelapenya - I think the concerns here are addressed - thanks in advance! |
|
I'm on PTO for this week, will take a look then 🙏 |
stevenh
requested changes
Aug 5, 2024
oleiman
force-pushed
the
redpanda-extra-config
branch
from
86985f0 to
cc28e93
Compare
|
force push some CR feedback:
|
stevenh
requested changes
Aug 6, 2024
oleiman
force-pushed
the
redpanda-extra-config
branch
from
cc28e93 to
5899844
Compare
|
force push contents:
|
|
Thanks for the reviews @stevenh - I think we've addressed all of your comments; please lmk if you have any lingering concerns 🙂 |
stevenh
requested changes
Aug 6, 2024
oleiman
force-pushed
the
redpanda-extra-config
branch
from
5899844 to
0e1db02
Compare
mdelapenya
approved these changes
Aug 7, 2024
stevenh
approved these changes
Aug 7, 2024
mdelapenya
changed the title
mdelapenya
reviewed
Aug 7, 2024
WithBootstrapConfig adds an arbitrary config kvp to the Redpanda container. Per the name, this config will be interpolated into the generated bootstrap config file, which is particularly useful for configs requiring a restart when otherwise applied to a running Redpanda instance. Includes a test that sets a couple of restart-requiring cluster configs and checks a) that the values are reflected in the config state at run time AND b) that the cluster does not need a restart. (b) demonstrates that the configs were bootstrapped rather than applied to a live cluster. Signed-off-by: Oren Leiman <[email protected]>
oleiman
force-pushed
the
redpanda-extra-config
branch
from
0e1db02 to
98389fe
Compare
mdelapenya
added a commit
that referenced
this pull request
Aug 9, 2024
* main: fix(compose): remove test volumes (#2712) chore(mysql): add missing error check in example (#2707) chore: remove unused params from defaultPreCreateHook (#2714) docs: improve docs for container methods (#2713) chore(registry): disable build log (#2711) chore: remove obsolete compose version (#2710) chore: improve lifecycle errors (#2708) docs: add consistent snippets for network creation (#2703) test: add retry on system error test (#2687) Redpanda Module: Add option for arbitrary bootstrap config (#2666) feat(inbucket): expose POP3 and wait for all ports (#2690) fix(wait): data race in test (#2698) fix(milvus): racy container setup (#2693) fix(mongodb): replica test failures (#2699) test: racy port creation in port forwarding tests (#2688) fix: port forwarding race condition (#2686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WithBootstrapConfig adds an arbitrary config kvp to the Redpanda container. Per the name, this config will be interpolated into the generated bootstrap config file, which is particularly useful for configs requiring a restart when otherwise applied to a running Redpanda instance.
Why is it important?
Several Redpanda cluster config properties can be updated live but require a node restart to take effect. The simplest way to expose these to testcontainer consumers is to provide generic access prior to container startup.
An example usage case is an integration test for a particularly memory hungry Wasm Data Transform, where tuning the per core and per function memory limits in a flexible, implementation driven way may be the difference between testing or not testing that function.
Related issues