chore(deps): bump github.com/docker/docker from v25.0.5 to v26.1.4

[thaJeztah]

What does this PR do?

Updating the docker dependency to the current release.

• rename variables that shadowed imports
• Update docker and dependencies
• Remove uses of deprecated API types
• Deprecate network.WithCheckDuplicate(), which is automatically set on older API versions
• Deprecate NetworkCreate.CheckDuplicate
• Remove uses of network.WithCheckDuplicate()

Why is it important?

Related issues

• closes [Bug]: v0.31.0 failing due to docker type removed in docker/docker dependency #2583

[netlify]

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	e434d06
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/666cbf199843f40008d88e56
😎 Deploy Preview	https://deploy-preview-2584--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[thaJeztah]

Think I have them all and changed them all back 😄

[mdelapenya]

Thanks for this! I'm enabling the CI now

[mdelapenya]

Oh you probably need to run make lint locally to detect and fix the deprecations

[thaJeztah]

oh! good one; I should've read the docs; let me check

[mdelapenya]

I should've read the docs

if the docs include reading the GH workflow, then you are right... otherwise it's my fault not having the CONTRIBUTING guidelines up-to-date 🙈

[thaJeztah]

Yup, looks like I missed one type 😂 I think it's ok now 🤞

[mdelapenya]

Perfect, lint passed! 🚀 Waiting for the CI to merge

[thaJeztah]

Hm... looks like some failures 🤔 fun!

run golangci-lint
  Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=modules/artemis --verbose] in [/home/runner/work/testcontainers-go/testcontainers-go/modules/artemis] ...
  Error: undefined: testcontainers (typecheck)
  Error: undefined: testcontainers (typecheck)
  Error: undefined: testcontainers (typecheck)
  Error: c.PortEndpoint undefined (type *Container has no field or method PortEndpoint) (typecheck)
  Error: c.PortEndpoint undefined (type *Container has no field or method PortEndpoint) (typecheck)

[thaJeztah]

I don't see that locally; or at least, don't see something immediately wrong in here;

testcontainers-go/modules/artemis/artemis.go

Line 38 in 2681ae4

return c.PortEndpoint(ctx, nat.Port(defaultBrokerPort), "")

[thaJeztah]

Wondering if it's golangci-lint needing an update for newer Go versions 🤔

golangci/golangci-lint-action@9d1e0624a798bb64f6c3cea93db47765312263dc
  with:
    version: v1.55.2
    working-directory: modules/artemis
    args: --verbose
    skip-cache: true
    github-token: ***
    only-new-issues: false
    skip-save-cache: false
    install-mode: binary
  env:
    TESTCONTAINERS_RYUK_DISABLED: false
    RYUK_CONNECTION_TIMEOUT: 60s
    RYUK_RECONNECTION_TIMEOUT: 10s

[mdelapenya]

Let me try to lint all modules locally 🙏

[mdelapenya]

Each submodule needed to mod-tidy again, I ran make tidy-all for that. This brings me the chance to improve the contributing docs ASAP

[thaJeztah]

oh! missed that one; thanks!

[mdelapenya]

@thaJeztah #2586