Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for Exec method #2451

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

gustavosbarreto
Copy link
Contributor

What does this PR do?

Adds documentation for the Exec method in the DockerContainer struct.

Why is it important?

The documentation emphasizes that reading directly from the io.Reader may result in unexpected bytes due to custom stream multiplexing headers. It recommends using stdcopy.StdCopy() from the Docker API to properly separate the stdout and stderr.

See: https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/503

@gustavosbarreto gustavosbarreto requested a review from a team as a code owner March 27, 2024 13:21
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 7f1af65
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/661d63019cf47100084c6ece
😎 Deploy Preview https://deploy-preview-2451--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docker.go Outdated Show resolved Hide resolved
@gustavosbarreto
Copy link
Contributor Author

If PR #2452 gets merged, I'll make sure to update the documentation to reflect the changes, specifically mentioning the utilization of the Multiplexed option.

@mdelapenya
Copy link
Member

If PR #2452 gets merged, I'll make sure to update the documentation to reflect the changes, specifically mentioning the utilization of the Multiplexed option.

PR was merged, so I think it's time to update the docs in this one. Thank you!!

Adds documentation for the Exec method in the DockerContainer struct.
@gustavosbarreto
Copy link
Contributor Author

If PR #2452 gets merged, I'll make sure to update the documentation to reflect the changes, specifically mentioning the utilization of the Multiplexed option.

PR was merged, so I think it's time to update the docs in this one. Thank you!!

Docs updated!

@mdelapenya mdelapenya self-assigned this Apr 15, 2024
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Apr 15, 2024
@mdelapenya mdelapenya merged commit 441d5b2 into testcontainers:main Apr 25, 2024
104 checks passed
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Apr 26, 2024
* main: (34 commits)
  break: return error from Customize request option (testcontainers#2267)
  fix: wrong copy paste (testcontainers#2515)
  docs: add documentation for Exec method (testcontainers#2451)
  docs: document the SSHd tunnel (testcontainers#2514)
  fix: enhance host configuration port binding (testcontainers#2512)
  feat: forward host ports to a container using an SSH tunnel (testcontainers#2471)
  Update follow_logs.md with adding missing package (testcontainers#2513)
  fix: don't retry on permanent APIClient errors (testcontainers#2506)
  feat: support overriding the default recreate options for compose (testcontainers#2511)
  feat: support passing io.Reader for compose files when creating a compose instance (testcontainers#2509)
  chore: add funding button for testcontainers (testcontainers#2510)
  feat: support Ryuk for the compose module (testcontainers#2485)
  chore(deps): bump golang.org/x/net in modules (minio, gcloud, weaviate, compose, qdrant, couchbase, k3s, milvus, mockserver, pulsar, kafka) (testcontainers#2505)
  fix: fallback to URL-path when parsing auth config URL without scheme (testcontainers#2488)
  fix(postgres): Fix the non-default dbname error (testcontainers#2489)
  feat: Bump default postgres version (testcontainers#2481)
  support Dolt (testcontainers#2177)
  chore: create TLS certs in a consistent manner (testcontainers#2478)
  chore(deps): bump idna from 3.6 to 3.7 (testcontainers#2480)
  Elasticsearch disable CA retrieval when ssl is disabled (testcontainers#2475)
  ...
mdelapenya added a commit to khartld/testcontainers-go that referenced this pull request May 7, 2024
* main: (44 commits)
  feat: expose JSON representation of a container with Inspect (testcontainers#2534)
  chore(deps): bump test-summary action to v2.3 (testcontainers#2535)
  chore(deps): bump jinja2 from 3.1.3 to 3.1.4 (testcontainers#2533)
  Update devcontainer image (testcontainers#2531)
  chore(influxdb): include more characters in wait for log regex (testcontainers#2532)
  fix(compose): avoid race conditions when caching services (testcontainers#2528)
  chore(deps): bump golangci/golangci-lint-action from 3.7.0 to 5.1.0 (testcontainers#2525)
  chore(deps): bump mkdocs-material from 8.2.7 to 9.1.21 (testcontainers#2524)
  chore(compose): return error in options (testcontainers#2520)
  chore(deps): bump github.com/compose-spec/compose-go/v2 from v2.0.0-rc8 to v2.1.0 (testcontainers#2519)
  chore(deps): bump github.com/containerd/containerd from 1.7.12 to 1.7.15 (testcontainers#2517)
  break: return error from Customize request option (testcontainers#2267)
  fix: wrong copy paste (testcontainers#2515)
  docs: add documentation for Exec method (testcontainers#2451)
  docs: document the SSHd tunnel (testcontainers#2514)
  fix: enhance host configuration port binding (testcontainers#2512)
  feat: forward host ports to a container using an SSH tunnel (testcontainers#2471)
  Update follow_logs.md with adding missing package (testcontainers#2513)
  fix: don't retry on permanent APIClient errors (testcontainers#2506)
  feat: support overriding the default recreate options for compose (testcontainers#2511)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants