feat: add module to support InfluxDB v1.x #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmorel-35
reviewed
Oct 1, 2023
eddumelendez
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Thanks for your contribution, @JJCinAZ ! I left some comments. Also, I think it should be influxdbv1 instead. Taking into account v2 will be supported anytime soon. WDYT @mdelapenya ?
|
Hey @JJCinAZ I'd recommend you using our module generator to bootstrap the module, as it will generate the right files also updating the descriptors files (GH actions, mkdocs, etc) 🙏 |
mdelapenya
reviewed
Oct 9, 2023
mdelapenya
reviewed
Oct 9, 2023
mdelapenya
reviewed
Oct 9, 2023
mdelapenya
added
feature
mdelapenya
reviewed
Oct 11, 2023
Co-authored-by: Eddú Meléndez Gonzales <[email protected]>
Fix copy/paste error Co-authored-by: Manuel de la Peña <[email protected]>
|
@mdelapenya I think that InfluxDB v2 is an abandoned product in so far as Influx has completely changed for v3 and abandoned the Flux language they introduced in v2. At this point, I have little faith they will actually have an OSS v3, so many of us are stuck at v1.8 until we migrate completely. If someone else has need for good v2 support, we can revisit how to make that happen. |
So your intention is to create an InfluxDB v1-only module, right? |
|
Yes, v1 only.
On Oct 18, 2023, at 12:54 AM, Manuel de la Peña ***@***.***> wrote:
If someone else has need for good v2 support, we can revisit how to make that happen.
So your intention is to create an InfluxDB v1-only module, right?
—
Reply to this email directly, view it on GitHub<#1703 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACMBST47SPIB6OSNRFYJBCDX76DKXAVCNFSM6AAAAAA5N2MQBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXHA4DQMZUGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
* main: (239 commits) Move the container and config tests into a test package (testcontainers#2242) Added error handling for context.Canceled in log reading code (testcontainers#2268) chore: updated docker compose version (testcontainers#2340) Add method for getting Weaviate's gRPC port (testcontainers#2339) chore: use withEnv in localstack module (testcontainers#2337) docs: fix wrong copy&paste (testcontainers#2338) fix: consul race on HTTP port (testcontainers#2336) chore(deps): bump mkdocs-material from 8.2.7 to 9.5.13 (testcontainers#2334) feat: add openfga module (testcontainers#2332) chore: retire dependabot (testcontainers#2325) chore: check that the new version is not empty (testcontainers#2331) chore: prepare for next minor development cycle (0.30.0) chore: use new version (v0.29.1) in modules and examples fix: incorrect version chore: prepare for next minor development cycle () chore: use new version (v0.29.0) in modules and examples generic.go: GenericContainer(): clearer error message (testcontainers#2327) chore: confirm support for new mongo images (testcontainers#2326) Add k3s WithManifest option (testcontainers#1920) chore(deps): bump google.golang.org/grpc in /modules/qdrant (testcontainers#2281) ...
|
@JJCinAZ sorry for not going on this PR since October 🙏 For that reason I did not want to cause you more trouble and went ahead and added some commits on top to update the code to the current state of the main branch. If possible, I'd like you to review it and give your 👍 👎 Thanks! |
|
@mdelapenya Thanks for adding the extra commits. I'm not familiar with the documentation system you use and do not use external linters in my Go projects, so thanks for cleaning those up. |
* main: feat: support for waiting for response headers (testcontainers#2349) chore(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (testcontainers#2392) redpanda: set entrypoint to the custom entrypoint file (testcontainers#2347)
* main: chore: bump ryuk to latest (testcontainers#2395)
* main: chore(deps): Bumping ChromaGo client version (testcontainers#2402) chore(deps): bump github.com/docker/docker from 25.0.3+incompatible to 25.0.5+incompatible (testcontainers#2444) feat: support passing io.Reader as ContainerFile (testcontainers#2401)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 26, 2024
* main: feat: add module to support InfluxDB v1.x (testcontainers#1703) feat: authenticate docker on PullImage (testcontainers#2446) feat: add distribution-registry module (testcontainers#2341) chore(deps): Bumping ChromaGo client version (testcontainers#2402) chore(deps): bump github.com/docker/docker from 25.0.3+incompatible to 25.0.5+incompatible (testcontainers#2444) feat: support passing io.Reader as ContainerFile (testcontainers#2401)
mdelapenya
added a commit
to coffeegoddd/testcontainers-go
that referenced
this pull request
Apr 12, 2024
* main: (115 commits) chore: create TLS certs in a consistent manner (testcontainers#2478) chore(deps): bump idna from 3.6 to 3.7 (testcontainers#2480) Elasticsearch disable CA retrieval when ssl is disabled (testcontainers#2475) fix: handle dockerignore exclusions properly (testcontainers#2476) chore: prepare for next minor development cycle (0.31.0) chore: use new version (v0.30.0) in modules and examples Fix url creation to handle query params when using HTTP wait strategy (testcontainers#2466) fix: data race on container run (testcontainers#2345) fix: logging deadlock (testcontainers#2346) feat(k6):Add remote test scripts (testcontainers#2350) feat: optimizes file copies to and from containers (testcontainers#2450) fix(exec): updates the `Multiplexed` opt to combine stdout and stderr (testcontainers#2452) Upgrade neo4j module to use features from v0.29.1 of testcontainers-go (testcontainers#2463) bug:Fix AMQPS url (testcontainers#2462) chore: more compose updates in comments chore: use "docker compose" (v2) instead of "docker-compose" (v1) (testcontainers#2464) chore(deps): bump github/codeql-action from 2.22.12 to 3.24.9 (testcontainers#2459) refactor: Add Weaviate modules tests (testcontainers#2447) feat(exitcode): Add exit code sugar method (testcontainers#2342) feat: add module to support InfluxDB v1.x (testcontainers#1703) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added support for InfluxDB v1.x containers.
Why is it important?
Enhanced testcontainers-go project.