Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modules): add artemis container #1440

Merged
merged 3 commits into from
Aug 14, 2023
Merged

feat(modules): add artemis container #1440

merged 3 commits into from
Aug 14, 2023

Conversation

abemedia
Copy link
Contributor

@abemedia abemedia commented Aug 5, 2023

What does this PR do?

Adds Apache ActiveMQ Artemis module.

Why is it important?

Artemis supports most common messaging protocols (AMQP, MQTT, STOMP) so this allows a fairly wide range of testing integrations with message broker clients.

Related issues

@abemedia abemedia requested a review from a team as a code owner August 5, 2023 17:01
@netlify
Copy link

netlify bot commented Aug 5, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d040324
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64da067d6f238e000745d155
😎 Deploy Preview https://deploy-preview-1440--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abemedia abemedia force-pushed the feat/artemis-module branch 4 times, most recently from 009473c to c9f2d61 Compare August 5, 2023 17:47
mdelapenya
mdelapenya reviewed Aug 5, 2023
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this module, at first sight it looks great!

I'm interested in your use case for this technology. Nevertheless, I will review it more deeply next Monday.

modules/artemis/example_test.go Show resolved Hide resolved
@abemedia
Copy link
Contributor Author

abemedia commented Aug 5, 2023

I'm currently working on a library similar to the standard library's database/sql but for message broker clients and this container lets me test three of the drivers.

@abemedia abemedia force-pushed the feat/artemis-module branch from c9f2d61 to 33af3bd Compare August 7, 2023 06:02
@mdelapenya mdelapenya self-assigned this Aug 7, 2023
@mdelapenya mdelapenya added the enhancement New feature or request label Aug 7, 2023
@abemedia abemedia force-pushed the feat/artemis-module branch from 33af3bd to 9b51c72 Compare August 7, 2023 17:44
eddumelendez
eddumelendez reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've been waiting for artemis and activemq images and thanks to your PR I realized those were available since couple of weeks ago.

docs/modules/artemis.md Show resolved Hide resolved
modules/artemis/artemis.go Show resolved Hide resolved
@abemedia abemedia force-pushed the feat/artemis-module branch from 8f2bd3e to a74913e Compare August 13, 2023 14:27
@abemedia abemedia force-pushed the feat/artemis-module branch from a74913e to 7cde9b1 Compare August 13, 2023 14:33
@abemedia
Copy link
Contributor Author

Hey @mdelapenya @eddumelendez, sorry about the delay but I was ill during the week.
Have just addressed all the PR comments and rebased on main.

@abemedia abemedia force-pushed the feat/artemis-module branch from 7cde9b1 to 8627291 Compare August 13, 2023 14:43
@abemedia abemedia force-pushed the feat/artemis-module branch from 8627291 to 06d9965 Compare August 13, 2023 14:45
mdelapenya
mdelapenya previously approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good to go! As mentioned in the new comments, I'll add the code snippets in a follow-up PR. 🚀

Thank you very much for your patience while reviewing the module 🙇

docs/modules/artemis.md
Comment on lines +57 to +59
```go
container, err := artemis.RunContainer(ctx, artemis.WithCredentials("user", "password"))
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to delay more this PR, I'll update the code snippets, using the codeinclude plugin in a follow-up PR.

modules/artemis/go.mod Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya
Copy link
Member

Merge now, as the CI build already passed and the latest commit updates go.mod, only

@mdelapenya mdelapenya merged commit d213b73 into testcontainers:main Aug 14, 2023
This was referenced Aug 14, 2023
Closed
Merged
@abemedia abemedia deleted the feat/artemis-module branch August 14, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya left review comments

@eddumelendez eddumelendez Awaiting requested review from eddumelendez

Assignees

@mdelapenya mdelapenya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abemedia @mdelapenya @eddumelendez