-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: ImageBuildOptions.Labels are overwritten #2632
Labels
bug
An issue with the library
Comments
rzajac
added a commit
to rzajac/testcontainers-go
that referenced
this issue
Sep 9, 2024
rzajac
added a commit
to rzajac/testcontainers-go
that referenced
this issue
Sep 9, 2024
rzajac
added a commit
to rzajac/testcontainers-go
that referenced
this issue
Sep 16, 2024
rzajac
added a commit
to rzajac/testcontainers-go
that referenced
this issue
Sep 16, 2024
rzajac
added a commit
to rzajac/testcontainers-go
that referenced
this issue
Sep 17, 2024
… nil and custom labels are present.
rzajac
added a commit
to rzajac/testcontainers-go
that referenced
this issue
Sep 17, 2024
mdelapenya
added a commit
that referenced
this issue
Sep 18, 2024
…ckerfile (#2775) * Fix #2632 - ImageBuildOptions.Labels are overwritten * Fix #2632 - fix linter errors. * Update internal/core/labels_test.go Co-authored-by: Steven Hartland <[email protected]> * Update internal/core/labels_test.go Co-authored-by: Steven Hartland <[email protected]> * Update internal/core/labels_test.go Co-authored-by: Steven Hartland <[email protected]> * Update internal/core/labels_test.go Co-authored-by: Steven Hartland <[email protected]> * Update container.go Co-authored-by: Manuel de la Peña <[email protected]> * Update internal/core/labels.go Co-authored-by: Manuel de la Peña <[email protected]> * Update container_test.go Co-authored-by: Manuel de la Peña <[email protected]> * Fix #2632 - remove given, when, then comments. * Update internal/core/labels.go Co-authored-by: Manuel de la Peña <[email protected]> * Fix #2632 - unit test update. * Update internal/core/labels_test.go Co-authored-by: Steven Hartland <[email protected]> * Fix #2632 - return error when destination labels map is nil and custom labels are present. * Update internal/core/labels_test.go Co-authored-by: Steven Hartland <[email protected]> * Update internal/core/labels.go Co-authored-by: Steven Hartland <[email protected]> * Update internal/core/labels.go Co-authored-by: Steven Hartland <[email protected]> * Update internal/core/labels.go Co-authored-by: Steven Hartland <[email protected]> * Update internal/core/labels_test.go Co-authored-by: Steven Hartland <[email protected]> * Update internal/core/labels_test.go Co-authored-by: Steven Hartland <[email protected]> * Fix #2632 - fix test. * Update container_test.go Co-authored-by: Manuel de la Peña <[email protected]> --------- Co-authored-by: Steven Hartland <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Testcontainers version
v0.32.0
Using the latest Testcontainers version?
Yes
Host OS
Linux
Host arch
x86
Go version
1.22
Docker version
Client: Docker Engine - Community Version: 27.0.3 API version: 1.46 Go version: go1.21.11 Git commit: 7d4bcd8 Built: Sat Jun 29 00:02:26 2024 OS/Arch: linux/amd64 Context: default Server: Docker Engine - Community Engine: Version: 27.0.3 API version: 1.46 (minimum version 1.24) Go version: go1.21.11 Git commit: 662f78c Built: Sat Jun 29 00:02:26 2024 OS/Arch: linux/amd64 Experimental: false containerd: Version: 1.7.18 GitCommit: ae71819c4f5e67bb4d5ae76a6b735f29cc25774e runc: Version: 1.7.18 GitCommit: v1.1.13-0-g58aa920 docker-init: Version: 0.19.0 GitCommit: de40ad0
Docker info
What happened?
In line
testcontainers-go/container.go
Lines 394 to 396 in d94455b
testcontainers-go/container.go
Lines 352 to 354 in d94455b
Relevant log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: