-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Ensure that stderr is empty after executing scripts #1116
Merged
HofmeisterAn
merged 8 commits into
testcontainers:develop
from
0xced:feature/assert-sdterr-empty
Mar 14, 2024
Merged
chore: Ensure that stderr is empty after executing scripts #1116
HofmeisterAn
merged 8 commits into
testcontainers:develop
from
0xced:feature/assert-sdterr-empty
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix When → Then typo comments for assertions
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0xced
force-pushed
the
feature/assert-sdterr-empty
branch
2 times, most recently
from
February 15, 2024 22:57
fdf380f
to
a23cebb
Compare
0xced
force-pushed
the
feature/assert-sdterr-empty
branch
from
February 17, 2024 09:10
a23cebb
to
0fcffb1
Compare
HofmeisterAn
changed the title
Always ensure that stderr is empty after executing scripts
chore: Ensure that stderr is empty after executing scripts
Mar 14, 2024
HofmeisterAn
added
the
chore
A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
label
Mar 14, 2024
HofmeisterAn
approved these changes
Mar 14, 2024
Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request add assertions to all tests that call
ExecScriptAsync
asserting that no error was written to stderr.Adding these assertions found two issues, in the MySQL and MongoDB implementations.
MySQL would produce the following warning on stderr:
This has been addressed in 925f426 by writing the configuration into
/etc/mysql/my.cnf
instead of passing it on the command line.MongoDB would produce the following error on stderr (when using the
mongo:4.4
image in theMongoDbV4Configuration
test):This has been addressed in 3ceeb4b by verifying if the
mongosh
binary exists and choosing the proper binary instead of runningmongosh || mongo
through/bin/sh
. This also simplified the mongosh command implementation.Finally, I also fixed some typos:
// When
should be// Then
in the assertion part of the tests.Why is it important?
Having stderr empty after successfully executing a script ensures that stderr will only contain actual errors and not spurious warnings or errors that are implementation detail errors that don't actually matter.