Skip to content

Commit

Permalink
chore: Add comment about Dockerfile variables
Browse files Browse the repository at this point in the history
  • Loading branch information
HofmeisterAn committed Aug 19, 2023
1 parent d3df73a commit 16e9d68
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Testcontainers/Images/DockerfileArchive.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ public IEnumerable<IImage> GetBaseImages()
.Where(line => !line.StartsWith("#", StringComparison.Ordinal))
.Select(line => FromLinePattern.Match(line))
.Where(match => match.Success)
// Until now, we are unable to resolve variables within Dockerfiles. Ignore base
// images that utilize variables. Expect them to exist on the host.
.Where(match => !match.Groups[imageGroup].Value.Contains('$'))
.Where(match => !match.Groups[imageGroup].Value.Any(char.IsUpper))
.ToArray();
Expand Down

0 comments on commit 16e9d68

Please sign in to comment.