Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR containerregistry/resource-manager/v2016_06_27_preview] [ACR] Scope map updates #394

Closed
Changes from 1 commit
Commits
Show all changes
214 commits
Select commit Hold shift + click to select a range
7711785
Disable Jetty by default. (#4964)
mitchdenny Aug 14, 2019
1b40f3a
Update package groups and add description in pom.xml for client libra…
srnagar Aug 14, 2019
7d24f9a
Event Hubs: Synchronous APIs Part 2 (#4970)
conniey Aug 14, 2019
6768fc9
Split the eventhubs client and data pipelines. (#4995)
mitchdenny Aug 14, 2019
58142d5
Add null check to fix spotbugs warning. (#4998)
conniey Aug 14, 2019
f173ae0
Seeing if we can speed up spotbugs (#4988)
JonathanGiles Aug 14, 2019
1ac4b2b
Enabling javadoc production for template. (#4963)
mitchdenny Aug 15, 2019
d44d8c3
Update link to Java Guidelines. (#4842)
adrianhall Aug 15, 2019
ca83bd9
Fixes on Check on checkstyle (#5003)
mssfang Aug 15, 2019
99e76b4
Update Storage swagger (#4981)
tg-msft Aug 15, 2019
6eb9e89
Added spock test framework and tests for queue service (#4940)
sima-zhu Aug 15, 2019
2eec622
Fix directory path. (#5012)
mitchdenny Aug 16, 2019
56dc993
Renaming IterableResponse to IterableStream (#5002)
JonathanGiles Aug 16, 2019
faa0ef7
Add tracing context to storage blobs (#4752)
samvaity Aug 16, 2019
6f0f73f
Checkstyle - Javadoc - enforce formating for param, return and throw …
vhvb1989 Aug 16, 2019
0beab53
Fixes URL hosts with path segments (#4917)
jianghaolu Aug 16, 2019
f95da5a
Add staging profile id. (#5025)
mitchdenny Aug 16, 2019
5eab1e6
Adding Gauri Prassad to Storage Code Owner List (#5023)
alzimmermsft Aug 16, 2019
e688eb6
Feature/unified pipeline staging profiles (#5018)
mitchdenny Aug 16, 2019
8d0068d
Check if the first character in the passed SASToken string is a quest…
alzimmermsft Aug 16, 2019
41418b4
Make StorageException a POJO (#4924)
alzimmermsft Aug 16, 2019
bb70bee
Smoke test for Java (#4805)
JonathanCrd Aug 16, 2019
076e0f8
Fix URL construction for Storage (#5027)
jianghaolu Aug 17, 2019
84fa1c4
Use constant ServiceBus audience instead of letting the user provide …
bainian12345 Aug 17, 2019
146e3a8
Major version bump for service bus. (#5029)
mitchdenny Aug 17, 2019
b111ad3
CosmosDB: package 2015-04-08 update. (#5033)
yaohaizh Aug 19, 2019
32b7f60
Okhttp bug fix (#4944)
g2vinay Aug 19, 2019
619c70a
Adding rule to expect a text description for deprecated javadoc tags …
vhvb1989 Aug 19, 2019
6f80595
CheckStyle: regex for suppression and a few fiexes for generated chec…
mssfang Aug 19, 2019
37a35dd
remove cosmosdb/data-plane (#5037)
christopheranderson Aug 19, 2019
3aa5160
Adding rule for enforcing final field usage - DoNotMerge until all is…
vhvb1989 Aug 19, 2019
aceafd6
Update Storage Files swagger to 2019-02-02 (#5028)
tg-msft Aug 19, 2019
fe2039f
CosmosDb: Remove blocking calls from CFP (#4602)
milismsft Aug 20, 2019
608b30f
Cosmos Direct TCP port from azure-cosmosdb v2.6.1 (#5042)
Aug 20, 2019
9884b8a
Custom CheckStyle Rule #9: Thrown exception use ClientLogger (#4566)
mssfang Aug 20, 2019
926de5b
Fix Install Linting Issues (#5057)
alzimmermsft Aug 20, 2019
84dfd55
Add tracing context to storage queue (#4934)
samvaity Aug 20, 2019
4d892df
Storage file service spock tests (#4991)
sima-zhu Aug 20, 2019
8935711
Fix the wrong imports (#5069)
sima-zhu Aug 21, 2019
1713919
Added fake connection string for playback tests. (#5072)
sima-zhu Aug 21, 2019
c0386ae
Bump version. (#5077)
mitchdenny Aug 21, 2019
5583eb0
Remove the Netty dependency from azure-core (#4572)
JonathanGiles Aug 22, 2019
a89afa0
Fix tests (#5080)
sima-zhu Aug 22, 2019
88f4a6f
Remove parent/pom.xml for Event Hubs Track 1 (#5090)
conniey Aug 22, 2019
64efc1b
Add tracing context in Storage Files (#4888)
samvaity Aug 22, 2019
6610afa
Add Impressions tracking link to READMEs (#5035)
g2vinay Aug 22, 2019
1234a3a
Tune management build triggering (#5078)
mitchdenny Aug 22, 2019
025647a
JavaDoc and parameter validation improvements (#5098)
conniey Aug 23, 2019
8bd0f47
Storage: Updated Listing Operation Return Types (#4803)
jaschrep-msft Aug 23, 2019
437afae
Playback and Record for Azure Storage Blob (#4971)
alzimmermsft Aug 23, 2019
e77284a
Update Swagger for Blobs and Files (#5094)
alzimmermsft Aug 23, 2019
ebbfe5a
getHandles to listHandles API changes. (#5055)
sima-zhu Aug 24, 2019
26cbf5a
Network: update package 2019_06_01. (#5095)
yaohaizh Aug 24, 2019
b1f7af5
Setup unified pipelines for sdk/authorization. (#4828)
mitchdenny Aug 26, 2019
c5730d1
Setup sdk/loganalytics for unified pipelines. (#4832)
mitchdenny Aug 26, 2019
416710a
Setup event grid for unified pipelines. (#4831)
mitchdenny Aug 26, 2019
9cee15b
Setup mediaservices for unified pipelines. (#4833)
mitchdenny Aug 26, 2019
5f61d18
Setup AI for unified pipelines. (#4827)
mitchdenny Aug 26, 2019
27cfb8e
Setup unified pipelines for sdk/cognitiveservices (#4830)
mitchdenny Aug 26, 2019
10f0d47
Add azure batch code owners (#4573)
bgklein Aug 26, 2019
3911729
Add Storage to SpotBugs Aggregate Report (#5089)
alzimmermsft Aug 26, 2019
e0f3c5a
Using ISO8601 instead of RFC1123 in response type (#5109)
alzimmermsft Aug 26, 2019
6d300f3
Added clearRange and remove the FileRangeWriteType (#5060)
sima-zhu Aug 26, 2019
9371a88
Fixed logger setup bug in Storage SDK test setup (#5112)
jaschrep-msft Aug 26, 2019
6b14ac0
add more eng entries to CODEOWNERS (#5110)
danieljurek Aug 26, 2019
23aa967
Added core-http-netty to set of artificts to publish. (#5107)
mitchdenny Aug 26, 2019
08fab71
Basic plumbing for pipeline caching. (#5086)
mitchdenny Aug 26, 2019
c1d5a52
Whitespace change to test pipeline config.
mitchdenny Aug 26, 2019
109b1a8
Add suppression for null check. (#5118)
mitchdenny Aug 27, 2019
b6a884d
Add netty library to set of docs generated so it can publish/sign. (#…
mitchdenny Aug 27, 2019
bb2c2bb
Enabling Cosmos for Unified Pipelines (#5102)
mitchdenny Aug 27, 2019
ba8dbc1
Removed azure-core-http-netty from the published artifact list. (#5121)
mitchdenny Aug 27, 2019
f6f89c8
CheckStyleRule-Javadoc-Codesnippet Batch#3, No.7 and No.8 (#4920)
mssfang Aug 27, 2019
e4ebe48
Improve Track 1 Event Hubs RBAC tests (#5133)
JamesBirdsall Aug 27, 2019
ed9d8b6
CustomCheckStyleRules: Good Logging Practice (#3359)
mssfang Aug 27, 2019
6ccb9c6
Remove Storage swagger files and reference azure-rest-api-specs (#5116)
tg-msft Aug 28, 2019
9ccb976
Custom CheckStyle rules: Fluent Method Name Check (#3366)
mssfang Aug 28, 2019
3eda854
Remove suppression and fix error. (#5143)
conniey Aug 28, 2019
d2df860
pom updates (#5151)
g2vinay Aug 28, 2019
b7bf03b
use expected artifact names (#5148)
danieljurek Aug 28, 2019
66fd3cd
Custom CheckStyle: Batch 2, Rule #5 and #10; Batch 3, Rule #1 and #6 …
mssfang Aug 28, 2019
d856608
Adding java automatic module names to all track two client libraries …
JonathanGiles Aug 29, 2019
ae1ffed
Allow instantiation of HttpClient sub-types (#5104)
JonathanGiles Aug 29, 2019
495f054
Removes parent POM. (#5162)
mitchdenny Aug 29, 2019
be4d001
Get appinsights build working, incl. docs. (#5122)
mitchdenny Aug 29, 2019
0fc82e4
Kusto: generate package 2019_05_15. (#5163)
yaohaizh Aug 29, 2019
debd816
Fixes 5144 (#5165)
conniey Aug 29, 2019
0d4e9c2
File and Queue SAS for Storage (#5129)
gapra-msft Aug 29, 2019
d46aace
Remove maven-enforcer-plugin from pom.client.xml (#5173)
alzimmermsft Aug 29, 2019
f9bb9ab
Updating clients to use CREATE_NEW for downloadToFile methods (#5135)
alzimmermsft Aug 29, 2019
140cccb
Add parent POMs to cache key. (#5164)
mitchdenny Aug 29, 2019
b3b7d5d
Deque to queue on CheckStyle rules (#5175)
mssfang Aug 29, 2019
794b2f5
Update Storage Testing Environment Variables (#5171)
alzimmermsft Aug 30, 2019
0b98a05
Proposal to create a base type of PagedFlux (#5084)
JonathanGiles Aug 30, 2019
80b0293
Adds Processing of StorageErrorException to StorageException in Files…
alzimmermsft Aug 30, 2019
aeead2c
Added service principle for storage user delegate key (#5176)
sima-zhu Aug 30, 2019
1ca98c0
Okhttp HttpClient plugin for azure-core (#5150)
anuchandy Aug 30, 2019
c4fd17d
Fixes for ThrowFromClientLogger rule: keyvault (#5179)
mssfang Aug 30, 2019
39e8879
Correct getAsyncClient in Sample code (#5166)
ragilr Aug 30, 2019
f4984b6
Added logger dependency (#5183)
sima-zhu Aug 30, 2019
81db79a
Add header. (#5184)
conniey Aug 30, 2019
d0efb33
Storage: Builder Impl Refactor (#5136)
jaschrep-msft Aug 30, 2019
743eefc
Upload any (#4935)
rickle-msft Aug 30, 2019
fecd819
Cosmos CFP: fix for stale lease and remove blocking call (#5085)
milismsft Aug 30, 2019
c49c9af
Cleanup Playback Tests (#5193)
alzimmermsft Aug 30, 2019
ffa4fb1
Build fix (#5195)
JonathanGiles Sep 1, 2019
aee48f9
Still trying to get everything passing under JDK 8 and 11 (#5196)
JonathanGiles Sep 1, 2019
03213c0
Fixing issue that is failing the build - pom.data.xml was removed but…
JonathanGiles Sep 2, 2019
c3a9bcf
Upgrade checkstyle, and fix a few issues identified along the way (#5…
JonathanGiles Sep 2, 2019
8bf5357
No more netty deps (#5199)
JonathanGiles Sep 2, 2019
6f5849d
Dep version update (#5206)
JonathanGiles Sep 2, 2019
bff4b51
Turn doclint up to all (#5210)
JonathanGiles Sep 2, 2019
125b40e
Move install of azure-sdk-parent up. (#5211)
mitchdenny Sep 2, 2019
94eeb99
Fix authorization publishing (#5203)
mitchdenny Sep 3, 2019
e03fa16
Update cognitive services parent POM to track 1 parent (#5202)
mitchdenny Sep 3, 2019
8b394a4
Bumping version number to 7.1 preview. (#5204)
mitchdenny Sep 3, 2019
f0587b2
Referenced track 1 parent and bumped version. (#5212)
mitchdenny Sep 3, 2019
f3988c2
Linked to track 1 parent pom and bumped version. (#5213)
mitchdenny Sep 3, 2019
1b5f1a9
Fix incorrect artifact name. (#5219)
mitchdenny Sep 3, 2019
702a38a
Amqp tracing support (#5061)
samvaity Sep 3, 2019
066e3ba
Add support for user proxy configuration (#3631)
conniey Sep 3, 2019
c7e72a7
Add mvn install on parent/pom.xml (#5225)
conniey Sep 3, 2019
b1b7eaa
Event Processor load balancer (#5034)
srnagar Sep 3, 2019
d185d98
Storage: Basic Request Validation (#5188)
jaschrep-msft Sep 3, 2019
8b0c754
Misc fixes (#5190)
srnagar Sep 3, 2019
802351f
Avoid buffering for download in storage (#5115)
jianghaolu Sep 3, 2019
5e7f2d5
System properties (#5224)
conniey Sep 4, 2019
b111c62
Integrates okHttp into the build process. Resolves spotbugs and check…
JonathanGiles Sep 4, 2019
5e4cc59
Disabled test and increased timeout. (#5216)
mitchdenny Sep 4, 2019
47ffff7
Bumped version of jackon to 2.9.9.3 because of CVE. (#4965)
mitchdenny Sep 4, 2019
81a8f91
Fixed the issue which request id did not take down in json file. (#5230)
sima-zhu Sep 4, 2019
c58d822
Generate storage-file with JSON share permission API (#5227)
jianghaolu Sep 4, 2019
b83b91e
Adding okhttp dependency to spotbugs pom (#5238)
anuchandy Sep 4, 2019
c96291b
Fixes core app conig check style error (#5191)
mssfang Sep 4, 2019
7546718
HttpClient plugin updates: centralize buffer resource management in o…
anuchandy Sep 4, 2019
5f24a89
Add PagedFlux and PagedIterable to Files and Queues (#5186)
alzimmermsft Sep 4, 2019
774085d
Fail at end for running live tests (#5241)
alzimmermsft Sep 4, 2019
8132509
We need to build tests so that the azure-core test jar is available f…
JonathanGiles Sep 4, 2019
a749b65
Use logger.logExceptionAsError in Load balancer (#5240)
conniey Sep 4, 2019
559cdeb
Fixed the failed live tests (#5242)
sima-zhu Sep 4, 2019
690f8cb
Turn off shallow cloning. (#5231)
mitchdenny Sep 5, 2019
e401e65
Removed condition on spotbugs roll-up. (#5232)
mitchdenny Sep 5, 2019
f440dd6
Implement unexpectlengthexception in azure core (#5108)
sima-zhu Sep 5, 2019
534be8a
Policy: generate package 2019_06_01 (#5217)
xseeseesee Sep 5, 2019
a7771a9
Container Services: generate 2019 08 01 version (#5218)
ChenTanyi Sep 5, 2019
03d261e
Fixed the checkstyle complains. (#5260)
sima-zhu Sep 5, 2019
ef61656
Setting default connectionMode to DIRECT (#5262)
kushagraThapar Sep 5, 2019
6183444
Fix share permission APIs (#5149)
jianghaolu Sep 5, 2019
cab5d63
Update event processor API based on user study (#5093)
srnagar Sep 5, 2019
e7cf04d
Add synchronous Event Hub Consumer (#5253)
conniey Sep 6, 2019
ba38110
Fix OkHttp errors. (#5273)
conniey Sep 6, 2019
03765c4
Resources: generated package 2019_06_01 (#5274)
xseeseesee Sep 6, 2019
8e6000c
Enforce line length (120 characters) for code (#5127)
vhvb1989 Sep 6, 2019
e22b9e3
Identity server bug fix. (#5272)
g2vinay Sep 6, 2019
9411e74
Suppress LineLength for Track 1 (#5276)
conniey Sep 6, 2019
d85d75c
Storage restparity (#5233)
gapra-msft Sep 6, 2019
08789cb
Storage SAS Code Snippets (#5258)
gapra-msft Sep 6, 2019
98d623d
Adding sync api for scripts (#5105)
mbhaskar Sep 6, 2019
6aadf92
Fixed live test and only record tests that support playback (#5282)
alzimmermsft Sep 6, 2019
a471148
Update Windows VMImage (#5252)
chidozieononiwu Sep 6, 2019
50e8b3e
Msal extension + SharedTokenCacheCredential (#5152)
qarni Sep 6, 2019
f5720b7
[email protected] (#5285)
christopheranderson Sep 7, 2019
27ebd1f
Remove unused imports. (#5293)
conniey Sep 8, 2019
708e238
Get media services generating the right packages. (#5256)
mitchdenny Sep 9, 2019
30d4e0c
Disable condition on checkstyle step and add skip variable. (#5294)
mitchdenny Sep 9, 2019
f2ae605
Capture Encryption Header for Playback Tests (#5297)
alzimmermsft Sep 9, 2019
a55d5dd
Adds okhttp and netty artifacts. (#5301)
mitchdenny Sep 9, 2019
e4fadb3
Added support for put range from URL (#5290)
gapra-msft Sep 9, 2019
b936967
Increase memory for Maven (#5304)
mitchdenny Sep 9, 2019
3f6826b
Partition Manager implementation with Storage Blob (#5278)
srnagar Sep 9, 2019
45a5bdd
Add timeout for sync API in queue and file (#5251)
sima-zhu Sep 9, 2019
2052811
Set tier on upload/copy; Rehydrate Priority (#5229)
jaschrep-msft Sep 9, 2019
b44c98e
Fix compile issue due to Storage API change (#5309)
alzimmermsft Sep 9, 2019
ae4aad4
Cpk (#5291)
jaschrep-msft Sep 10, 2019
0c66044
Review Hand Crafted Model Classes (#5268)
alzimmermsft Sep 10, 2019
8188b57
Reduce memory footprint of integration tests (#5310)
conniey Sep 10, 2019
16e5dc5
Adding codeSnippets to Blob client and async client (#5245)
vhvb1989 Sep 10, 2019
6d7504b
Adding code snippets for sync and async container client (#5270)
vhvb1989 Sep 10, 2019
6eab834
Adding code snippets for blob client and container builders (#5279)
vhvb1989 Sep 10, 2019
34f7859
adding code snippets for BlobService Sync and Async clients (#5281)
vhvb1989 Sep 10, 2019
8c346f7
Event Hubs preview 3 documentation changes. (#5303)
conniey Sep 10, 2019
7dce43c
adding code snippets for BlockBlob Async and sync clients (#5249)
vhvb1989 Sep 10, 2019
abc9ea8
Fixing up queues (#5319)
alzimmermsft Sep 10, 2019
c846a67
CHANGELOG for AppConfiguration Preview 3 (#5325)
alzimmermsft Sep 10, 2019
3fb87be
Fork spotbugs to prevent build growing large. (#5331)
conniey Sep 10, 2019
a821b36
Updated change log for preview 3 (#5269)
sima-zhu Sep 10, 2019
7f0d64e
Changelog for Storage Blobs Preview 3 (#5302)
alzimmermsft Sep 10, 2019
b7885af
Build timeout fix (#5332)
g2vinay Sep 10, 2019
e442cc4
Update README.md
joshfree Sep 11, 2019
ab5796c
Update README.md
joshfree Sep 11, 2019
12f3795
KV certificates API Implementation (#5264)
g2vinay Sep 11, 2019
dba5c2b
KV Certificates Artifacts Generation Config (#5340)
g2vinay Sep 11, 2019
f3a0f2f
Update README for checkpoint store (#5315)
srnagar Sep 11, 2019
4375acb
Update package version to 1.0.0-preview.3
joshfree Sep 11, 2019
b03a83f
Bump versions for Preview 4 release (#5347)
conniey Sep 11, 2019
ee55fb0
Improve documentation for azure-identity (#5327)
jianghaolu Sep 11, 2019
085c857
Update README.md (#5350)
alzimmermsft Sep 11, 2019
7d0e983
Skip persisten cache tests in identity (#5308)
jianghaolu Sep 11, 2019
84720ac
Update EventProcessor sample. (#5352)
conniey Sep 11, 2019
9430735
Use Javabeans In Getters and Setters (#5338)
alzimmermsft Sep 12, 2019
a6bb33f
Use commit hash link for documentation (#5353)
alzimmermsft Sep 12, 2019
5ba941d
Fixed missing variable at live tests (#5357)
sima-zhu Sep 12, 2019
abcf57d
Modules for Blobs and Queues Encryption (#5322)
alzimmermsft Sep 12, 2019
5431213
Turn on Custom Checkstyles in Storage (#5363)
alzimmermsft Sep 12, 2019
f1d6a95
Fix logging (#5367)
srnagar Sep 13, 2019
d113267
Http Client README Updates (#5362)
g2vinay Sep 13, 2019
d2cf185
Regenerate custom vision prediction & training (#5369)
jianghaolu Sep 13, 2019
d822b94
Update README.md
joshfree Sep 13, 2019
1a008a6
Update README.md
joshfree Sep 13, 2019
bb4c837
Adding docs for dev env, build and tests for contributing
vhvb1989 Sep 13, 2019
3ad6c1f
Storage: regenerated package v2019_04_01 (#5377)
xseeseesee Sep 16, 2019
b8b555d
Clean-up integration tests (#5383)
conniey Sep 16, 2019
4bb9450
Rest proxy remove block from Schedulers (#5376)
sima-zhu Sep 16, 2019
25cbc08
Generated from 604a599550d7aa46f836e8b47376839971cdfbb7
Sep 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CheckStyle: regex for suppression and a few fiexes for generated chec…
…kstyle errors (Azure#5032)

* remove java code isImple check but move to suppression and add only check for public class for external Dependency check

* refactor and fixes errors

* add break
  • Loading branch information
mssfang authored Aug 19, 2019
commit 6f8059560d6de9f941cfae418fd056b6c49a1715
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Licensed under the MIT License.
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package com.azure.tools.checkstyle.checks;

@@ -49,15 +49,18 @@ public void visitJavadocToken(DetailNode javaDocTag) {
switch (javaDocTag.getType()) {
case JavadocTokenTypes.RETURN_LITERAL:
evaluateValidFormat(javaDocTag, JAVA_DOC_RETURN);
break;
case JavadocTokenTypes.PARAMETER_NAME:
evaluateValidFormat(javaDocTag, JAVA_DOC_PARAMETER);
break;
case JavadocTokenTypes.THROWS_LITERAL:
// Evaluate what is the format after the CLASS_NAME of a @throw
DetailNode throwFormat = JavadocUtil.getNextSibling(javaDocTag, JavadocTokenTypes.CLASS_NAME);
evaluateValidFormat(throwFormat, JAVA_DOC_THROW);
break;
case JavadocTokenTypes.DEPRECATED_LITERAL:
evaluateValidFormat(javaDocTag, JAVA_DOC_DEPRECATED);
break;
default:
break;
}
Original file line number Diff line number Diff line change
@@ -86,52 +86,26 @@
<!-- The constant name is public static. -->
<suppress checks="ConstantNames" files=".*[/\\]storage[/\\].*LoggingOptions.java"/>

<!-- Add NoImplInPublicAPI suppression for any test files (ie. ones that live under src/test/java). -->
<suppress checks="com.azure.tools.checkstyle.checks.NoImplInPublicAPI" files=".*[/\\]src[/\\]test[/\\]java[/\\].*\.java"/>

<!-- Add JavadocThrowsChecks suppression for any test or implementation files (ie. ones that live under src/test/java or implementation). -->
<suppress checks="com.azure.tools.checkstyle.checks.JavadocThrowsChecks" files="(.*[/\\]src[/\\]test[/\\]java[/\\].*)|(.*[/\\]implementation[/\\].*)\.java"/>

<!-- Custom checkstyle rules only check track 2 libraries -->
<suppress checks="com\.azure\.tools\.checkstyle\.checks\..+" files=".*[/\\]com[/\\]microsoft[/\\].*"/>

<!-- Custom checkstyle rules that don't apply to files under test package -->
<suppress checks="com.azure.tools.checkstyle.checks.ExternalDependencyExposedCheck" files=".*[/\\]src[/\\]test[/\\]java[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.ServiceClientInstantiationCheck" files=".*[/\\]src[/\\]test[/\\]java[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.ServiceClientBuilderCheck" files=".*[/\\]src[/\\]test[/\\]java[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.ServiceInterfaceCheck" files=".*[/\\]src[/\\]test[/\\]java[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.HttpPipelinePolicyCheck" files=".*[/\\]src[/\\]test[/\\]java[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.JavaDocFormatting" files=".*[/\\]src[/\\]test[/\\]java[/\\].*\.java"/>
<suppress checks="com\.azure\.tools\.checkstyle\.checks\.(ExternalDependencyExposedCheck|NoImplInPublicAPI|ServiceClientInstantiationCheck
|ServiceClientBuilderCheck|ServiceInterfaceCheck|HttpPipelinePolicyCheck|JavaDocFormatting|JavadocThrowsChecks)" files=".*[/\\]src[/\\]test[/\\]java[/\\].*\.java"/>

<!-- Custom checkstyle rules that don't apply to files under implementation package -->
<suppress checks="com.azure.tools.checkstyle.checks.ExternalDependencyExposedCheck" files=".*[/\\]implementation[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.ServiceClientInstantiationCheck" files=".*[/\\]implementation[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.ServiceClientBuilderCheck" files=".*[/\\]implementation[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.ServiceInterfaceCheck" files=".*[/\\]implementation[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.JavaDocFormatting" files=".*[/\\]implementation[/\\].*\.java"/>
<suppress checks="com\.azure\.tools\.checkstyle\.checks\.(ExternalDependencyExposedCheck|ServiceClientInstantiationCheck
|ServiceClientBuilderCheck|ServiceInterfaceCheck|JavaDocFormatting|JavadocThrowsChecks)" files=".*[/\\]implementation[/\\].*\.java"/>

<!-- Custom checkstyle rules that don't apply to files under samples package -->
<suppress checks="com.azure.tools.checkstyle.checks.ExternalDependencyExposedCheck" files=".*[/\\]samples[/\\].*\.java"/>
<suppress checks="com.azure.tools.checkstyle.checks.HttpPipelinePolicyCheck" files=".*[/\\]samples[/\\].*\.java"/>
<suppress checks="com\.azure\.tools\.checkstyle\.checks\.(ExternalDependencyExposedCheck|HttpPipelinePolicyCheck|JavadocPackage)" files=".*[/\\]samples[/\\].*\.java"/>

<!-- Don't apply custom Checkstyle rules to files under checkstyle package. -->
<suppress checks="com\.azure\.tools\.checkstyle\.checks\..+" files=".*[/\\]tools[/\\]checkstyle[/\\].*"/>

<!-- JavaPackage suppression -->
<suppress checks="JavadocPackage" files=".*[/\\]samples[/\\].*\.java"/>

<!-- OpenCensus should only be depended on from within the tracing-opencensus module -->
<suppress checks="IllegalImport" files=".*[/\\]com[/\\]azure[/\\]tracing[/\\]opentelemetry[/\\]*"/>

<!-- Suppress warnings for Event Processor until the usage of "Client" is discussed and resolved: https://github.com/Azure/azure-sdk/issues/321 -->
<suppress checks="com.azure.tools.checkstyle.checks.ServiceClientBuilderCheck" files=".*EventHubClientBuilder.java"/>

<!-- Any code in any package, it should never be a 'throw' keyword in the client library codebase except for in the client logger -->
<!-- <suppress checks="com.azure.tools.checkstyle.checks.ThrownClientLoggerCheck" files=".*[/\\]com[/\\]azure[/\\]core[/\\]util[/\\]logging[/\\]*"/>-->

<!-- Suppression for throws IOException Class, Will remove these classes after be able to define the error is IOException -->
<!-- <suppress checks="com.azure.tools.checkstyle.checks.ThrownClientLoggerCheck" files=".*[/\\]src[/\\]test[/\\]java[/\\]com[/\\]azure[/\\]core[/\\]implementation[/\\](.*RestProxyStressTests[/\\].*)|(.*util[/\\]FluxUtilTests[/\\].*)\.java"/>-->

<!-- Storage still depends on 1.0.0-preview.2 azure core. suppress this rule for now until storage has upgraded to preview-3 azure core-->
<suppress checks="com.azure.tools.checkstyle.checks.ServiceClientBuilderCheck" files=".*[/\\]storage[/\\].*\.java"/>
</suppressions>
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
import com.azure.core.http.policy.HttpPipelinePolicy;
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.implementation.util.ImplUtils;
import com.azure.core.util.configuration.Configuration;
@@ -65,6 +66,9 @@
* <li>{@link BlobClientBuilder#buildPageBlobAsyncClient()} - {@link PageBlobAsyncClient}</li>
* </ul>
*/
@ServiceClientBuilder(serviceClients = {BlobClient.class, BlobAsyncClient.class, AppendBlobClient.class,
AppendBlobAsyncClient.class, BlockBlobClient.class, BlockBlobAsyncClient.class, PageBlobClient.class,
PageBlobAsyncClient.class})
public final class BlobClientBuilder {
private static final String ACCOUNT_NAME = "accountname";
private static final String ACCOUNT_KEY = "accountkey";
@@ -94,7 +98,7 @@ public BlobClientBuilder() {
additionalPolicies = new ArrayList<>();
}

private AzureBlobStorageImpl buildImpl() {
private AzureBlobStorageImpl constructImpl() {
Objects.requireNonNull(endpoint);
Objects.requireNonNull(containerName);
Objects.requireNonNull(blobName);
@@ -155,7 +159,7 @@ public BlobClient buildBlobClient() {
* @throws NullPointerException If {@code endpoint}, {@code containerName}, or {@code blobName} is {@code null}.
*/
public BlobAsyncClient buildBlobAsyncClient() {
return new BlobAsyncClient(buildImpl(), snapshot);
return new BlobAsyncClient(constructImpl(), snapshot);
}

/**
@@ -179,7 +183,7 @@ public AppendBlobClient buildAppendBlobClient() {
* @throws NullPointerException If {@code endpoint}, {@code containerName}, or {@code blobName} is {@code null}.
*/
public AppendBlobAsyncClient buildAppendBlobAsyncClient() {
return new AppendBlobAsyncClient(buildImpl(), snapshot);
return new AppendBlobAsyncClient(constructImpl(), snapshot);
}

/**
@@ -206,7 +210,7 @@ public BlockBlobClient buildBlockBlobClient() {
* @throws NullPointerException If {@code endpoint}, {@code containerName}, or {@code blobName} is {@code null}.
*/
public BlockBlobAsyncClient buildBlockBlobAsyncClient() {
return new BlockBlobAsyncClient(buildImpl(), snapshot);
return new BlockBlobAsyncClient(constructImpl(), snapshot);
}

/**
@@ -231,7 +235,7 @@ public PageBlobClient buildPageBlobClient() {
* @throws NullPointerException If {@code endpoint}, {@code containerName}, or {@code blobName} is {@code null}.
*/
public PageBlobAsyncClient buildPageBlobAsyncClient() {
return new PageBlobAsyncClient(buildImpl(), snapshot);
return new PageBlobAsyncClient(constructImpl(), snapshot);
}

/**
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
import com.azure.core.http.policy.HttpPipelinePolicy;
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.implementation.util.ImplUtils;
import com.azure.core.util.configuration.Configuration;
@@ -51,6 +52,7 @@
* Once all the configurations are set on this builder, call {@code .buildClient()} to create a
* {@link BlobServiceClient} or {@code .buildAsyncClient()} to create a {@link BlobServiceAsyncClient}.
*/
@ServiceClientBuilder(serviceClients = {BlobServiceClient.class, BlobServiceAsyncClient.class})
public final class BlobServiceClientBuilder {
private static final String ACCOUNT_NAME = "accountname";
private static final String ACCOUNT_KEY = "accountkey";
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
import com.azure.core.http.policy.HttpPipelinePolicy;
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.implementation.util.ImplUtils;
import com.azure.core.util.configuration.Configuration;
@@ -51,6 +52,7 @@
* Once all the configurations are set on this builder, call {@code .buildClient()} to create a
* {@link ContainerClient} or {@code .buildAsyncClient()} to create a {@link ContainerAsyncClient}.
*/
@ServiceClientBuilder(serviceClients = {ContainerClient.class, ContainerAsyncClient.class})
public final class ContainerClientBuilder {
private static final String ACCOUNT_NAME = "accountname";
private static final String ACCOUNT_KEY = "accountkey";
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.RetryPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.util.configuration.Configuration;
import com.azure.core.util.configuration.ConfigurationManager;
@@ -70,6 +71,7 @@
* @see SASTokenCredential
* @see SharedKeyCredential
*/
@ServiceClientBuilder(serviceClients = {DirectoryClient.class, DirectoryAsyncClient.class})
public class DirectoryClientBuilder {
private static final String ACCOUNT_NAME = "accountname";
private final List<HttpPipelinePolicy> policies;
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.RetryPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.util.configuration.Configuration;
import com.azure.core.util.configuration.ConfigurationManager;
@@ -71,6 +72,7 @@
* @see SASTokenCredential
* @see SharedKeyCredential
*/
@ServiceClientBuilder(serviceClients = {FileClient.class, FileAsyncClient.class})
public class FileClientBuilder {
private static final String ACCOUNT_NAME = "accountname";
private final List<HttpPipelinePolicy> policies;
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.RetryPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.util.configuration.Configuration;
import com.azure.core.util.configuration.ConfigurationManager;
@@ -70,6 +71,7 @@
* @see SASTokenCredential
* @see SharedKeyCredential
*/
@ServiceClientBuilder(serviceClients = {FileServiceClient.class, FileServiceAsyncClient.class})
public final class FileServiceClientBuilder {
private static final String ACCOUNT_NAME = "accountname";
private final List<HttpPipelinePolicy> policies;
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.RetryPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.util.configuration.Configuration;
import com.azure.core.util.configuration.ConfigurationManager;
@@ -70,6 +71,7 @@
* @see SASTokenCredential
* @see SharedKeyCredential
*/
@ServiceClientBuilder(serviceClients = {ShareClient.class, ShareAsyncClient.class})
public class ShareClientBuilder {
private static final String ACCOUNT_NAME = "accountname";
private final List<HttpPipelinePolicy> policies;
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.RetryPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.implementation.util.ImplUtils;
import com.azure.core.util.configuration.Configuration;
@@ -76,6 +77,7 @@
* @see SASTokenCredential
* @see SharedKeyCredential
*/
@ServiceClientBuilder(serviceClients = {QueueClient.class, QueueAsyncClient.class})
public final class QueueClientBuilder {
private static final ClientLogger LOGGER = new ClientLogger(QueueClientBuilder.class);
private static final String ACCOUNT_NAME = "accountname";
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
import com.azure.core.http.policy.RequestIdPolicy;
import com.azure.core.http.policy.RetryPolicy;
import com.azure.core.http.policy.UserAgentPolicy;
import com.azure.core.implementation.annotation.ServiceClientBuilder;
import com.azure.core.implementation.http.policy.spi.HttpPolicyProviders;
import com.azure.core.util.configuration.Configuration;
import com.azure.core.util.configuration.ConfigurationManager;
@@ -73,6 +74,7 @@
* @see SASTokenCredential
* @see SharedKeyCredential
*/
@ServiceClientBuilder(serviceClients = {QueueServiceClient.class, QueueServiceAsyncClient.class})
public final class QueueServiceClientBuilder {
private static final ClientLogger LOGGER = new ClientLogger(QueueServiceClientBuilder.class);
private static final String ACCOUNT_NAME = "accountname";