Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR datafactory/resource-manager/v2017_09_01_preview] [DataFactory] Add Chaining Trigger #296

Conversation

openapi-sdkautomation[bot]
Copy link

mitchdenny and others added 30 commits August 14, 2019 13:10
Adds a flag to the pipeline which controls whether it is a track 1 or track 2 build.
* Formatting changes in EventHubAsyncProducer.

* Adding EventHubClient, EventHubConsumer, and EventHubProducer.

* Exposing EventHubClient creation in EventHubClientBuilder.

* EventHubClient, Consumer and Producer implements Closeable.

* Fixing sample by removing event hub instance from namespace connection string.

* Remove unneeded sample in EventHubClientBuilder.

* Add EventHubClient to builder annotation.

* Update EventHubClientBuilder samples. Remove unneeded ones.

* Update samples in EventHubClientBuilder.

* Fixing links to EventHubAsyncProducer samples.

* Adding EventHubProducer code samples.

* Update from Iterable to IterableResponse.

* Make test contents package-private.

* Adding tests for EventHubProducer.

* Simplifying creation of EventHubAsyncProducer

* Select correct retryDuration when constructing EventHubProducer.

* Adding EventHubProducer tests.

* Rename EventHubClientIntegrationTest -> EventHubAsyncClientIntegrationTests

* Add integration tests for EventHubClient.

* Make EventHubConsumer methods public
* Split the eventhubs client and data pipelines.

* Removed redundant modules section.

* Specified artifacts for data pipeline.
* Seeing if we can speed up spotbugs by not forking the JVM for each module
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check

* fixes

* Update eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml

suggest changes on comments

Co-Authored-By: Connie Yau <[email protected]>
* Move Storage to official swagger files

There are no (meaningful) code changes except the attribute in
BlobHierarchyListSegment that I can't trace to the swagger

* Upgrade blobs swagger to 2019-02-02

Note that additional work will have to be done to patch our higher level code to
pass new parameters to existing APIs

* Fixes to Swagger generation and updating to use new protocol layer

* Fixed appendBlock content-type, added SpotBug exclusions for autogen code

* Update README.md

* Fixed incorrect exclude
* Migrate queue to spock test framework

* Remove all Junit tests and dependencies
…literals usage (#4994)

* Adding javaDoc formating rule

* Adding fixes for javadoc formatting
* Created StorageException for Files and Queues, moved it into models for Blobs, made it a POJO

* Using getX naming and cleaned up unit test imports

* Fixed additional imports

* Fixed import and ignored issue with enum serialization
* Smoke Test for Key Vault, Storage and Identity SDK

* Create EventHubs.java

* Update EventHubs.java

* Update KeyVaultSecrets.java

* Update App.java

* Create CosmosDB files

* CosmosDB finallized

* Update EventHubs.java

* Handling pre-cleaning the resource

* Update App.java

* Concurrency support

* Update pom.xml

* Review feedback

* Reactive async in Cosmos

* Use of Logger

* Env Variables names changed

* Create README.md

* Use of logger in error message

* Location changed to /eng/

* Create smoke-test.yml

* Update smoke-test.yml

* Update smoke-test.yml

* Update smoke-test.yml

* Update README.md

* Website in pom.xml

* MIT headers

* static final named correctly

* Avoiding import.*

* nit: extra blank lines and logger
KV Track 1 OkHttp Bug fix.
…kstyle errors (#5032)

* remove java code isImple check but move to suppression and add only check for public class for external Dependency check

* refactor and fixes errors

* add break
alzimmermsft and others added 23 commits August 26, 2019 11:19
* Added storage to the aggregate reports

* Fixing SpotBug issues

* One last SpotBug fix

* Fixed invalid use in sample
* Added clearRange and remove the FileRangeWriteType
* Fixed bytebuffer issue.
* add more eng entries to CODEOWNERS with use the correct owners
* Basic plumbing for pipeline caching.

* Using new key format.

* Add caching to build and analyze phases.

* Narrowing scope of fingerprint.

* Removed caching from analyze step.

* Adding caching kill switch.
Commit directly to master to test a change (need to simulate a CI trigger).
* Roll back customizations to ci.yml for cosmos.

* Created a special stage template for cosmos.

* Tweaked template path.

* Added globals reference in tests job.
* Removed azure-core-http-netty from the published artifact list.

* Actually remove the artifact.
This PR includes the requirement of Javadoc annotation @codesnippet @code, check:

Use {@codesnippet ...} instead of '<code>', '<pre>', or '{@code ...}' if these tags span multiple lines. Inline code samples are fine as-is.
@codesnippet description should match naming pattern requirement below:

Package, class and method names should be concatenated by dot '.'. Ex., packageName.className.methodName
Methods arguments should be concatenated by dash '-'. Ex. string-string for methodName(String s, String s2)
Use '#' to concatenate 1) and 2), ex packageName.className.methodName#string-string.
Fixed and Suppress checkstyle errors :

A minor fix for HttpPipeLinePolicyCheck, which to find a correct package name.
Fixed all non-critical errors but suppress those critical errors so code owner can fix them when they are available.
Good Logging Practice
    1) ClientLogger in public API should all named 'logger', public API classes are those classes that are declared
       as public and that do not exist in an implementation package or subpackage.
    2) ClientLogger should be non-static instance logger
    3) Should not use any external logger class, only use ClientLogger. No slf4j, log4j, or other logging imports are allowed.
      'System.out' and 'System.err' is not allowed as well.
    4) All classes should use ClientLogger as logger only but except ClientLogger itself
* Remove Storage swagger files and reference azure-rest-api-specs

Also includes a few changes to Queues that were there before switching swagger
references (it may not have been regenerated in awhile?).

* Removing last swagger file from repo, fixing tests to comply with new swagger generation

* Added comment to get StorageErrorCode into the Swagger
Fluent Methods: All methods that return an instance of the class, and that have one parameter.
The method name should not start with any word in the list of avoidStartWords.
All methods should not be declared to throws any checked exceptions.
KV track 1 bug fix + pom updates
* use expected artifact names
* remove -complete artifact from kv unified pipeline
* remove -test from keyvault artifact specification (it does not output all currently expected artifacts)
…4712)

Batch 2

Rule # 5
Service client methods: All methods that are in a class annotated with @ServiceClient, where the method has a @ServiceMethod annotation, should follow these rules:

Methods names should follow a common vocabulary. Refer to Java spec for this naming pattern https://azure.github.io/azure-sdk/java_design.html.
Method names imply certain rules around expected return type - these should all be validated.
Methods should not have 'Async' added to their method name.
Return types of async and sync clients should be as per guidelines: [this check will be ignored for now since I am still struggling on how to get the Reflection working in the code-quality-check]
Return type for async collection should be of type ? extends PagedFlux
Return type for async single value should be of type ? extends Mono
Return type for sync collection should be of type ? extends PagedIterable
Return type for sync single value should be of type ? extends Response
Rule # 10
'withResponse' naming pattern: All methods annotated with @ServiceMethod that return a Response (or Mono) must have their method name end with 'withResponse'. If the service method does not return a Response or Mono, it must not end with 'withResponse'.

Batch 3

Rule # 1
Context in all the right places: Context should be passed in as an argument to all public methods annotated with @ServiceMethod that return Response in sync clients.

Only in the sync case: E.g. we want this: Public Response getFooWithResponse(int x, int y, Context c)
In the async case, we should check to ensure we have no service methods that take Context!
Rule # 6
Async client should have async = true property set in @ServiceClient annotation

To validate this, if the class has @ServiceClient annotation and if the classname AsyncClient, verify that the async property of @ServiceClient annotation is set to true.
Similarly, if the class has @ServiceClient annotation and if the classname is Client, verify that the async property of @ServiceClient annotation is set to false
Change class Context to be final
…5154)

* Adding java automatic module names to all track two client libraries. Removing a few unused dependencies. Enforcing a Maven baseline of 3.6.1 to tighten our tooling scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.