Generated from edd74f0a1be6f17caa185525a63e594aef956acc (#224)

Addressed review comments.
test-repo-billy · Aug 28, 2019 · 1bb4caa · 1bb4caa
1 parent 7891b67
commit 1bb4caa
Show file tree

Hide file tree

Showing 8 changed files with 85 additions and 35 deletions.
diff --git a/policy/resource-manager/v2016_12_01/pom.xml b/policy/resource-manager/v2016_12_01/pom.xml
@@ -11,15 +11,15 @@
     <parent>
         <groupId>com.microsoft.azure</groupId>
         <artifactId>azure-arm-parent</artifactId>
-        <version>1.1.0</version>
-        <relativePath>../../../pom.management.xml</relativePath>
+        <version>0.0.3-beta</version>
+        <relativePath>../../../pom.xml</relativePath>
     </parent>
     <artifactId>azure-mgmt-policy</artifactId>
-    <version>1.0.0-beta-1</version>
+    <version>1.0.0-beta</version>
     <packaging>jar</packaging>
     <name>Microsoft Azure SDK for Authorization Management</name>
     <description>This package contains Microsoft Authorization Management SDK.</description>
-    <url>https://github.com/Azure/azure-libraries-for-java</url>
+    <url>https://github.com/Azure/azure-sdk-for-java</url>
     <licenses>
         <license>
             <name>The MIT License (MIT)</name>
@@ -28,8 +28,8 @@
         </license>
     </licenses>
     <scm>
-        <url>scm:git:https://github.com/Azure/azure-libraries-for-java</url>
-        <connection>scm:git:[email protected]:Azure/azure-libraries-for-java.git</connection>
+        <url>scm:git:https://github.com/Azure/azure-sdk-for-java</url>
+        <connection>scm:git:[email protected]:Azure/azure-sdk-for-java.git</connection>
         <tag>HEAD</tag>
     </scm>
     <properties>

diff --git a/..._01/src/main/java/com/microsoft/azure/management/policy/v2016_12_01/PolicyAssignment.java b/..._01/src/main/java/com/microsoft/azure/management/policy/v2016_12_01/PolicyAssignment.java
@@ -84,6 +84,8 @@ interface Blank extends WithScope {
         interface WithScope {
            /**
             * Specifies scope.
+            * @param scope The scope of the policy assignment
+            * @return the next definition stage
             */
             WithCreate withScope(String scope);
         }
@@ -94,6 +96,8 @@ interface WithScope {
         interface WithDescription {
             /**
              * Specifies description.
+             * @param description This message will be part of response in case of policy violation
+             * @return the next definition stage
              */
             WithCreate withDescription(String description);
         }
@@ -104,6 +108,8 @@ interface WithDescription {
         interface WithDisplayName {
             /**
              * Specifies displayName.
+             * @param displayName The display name of the policy assignment
+             * @return the next definition stage
              */
             WithCreate withDisplayName(String displayName);
         }
@@ -114,6 +120,8 @@ interface WithDisplayName {
         interface WithParameters {
             /**
              * Specifies parameters.
+             * @param parameters Required if a parameter is used in policy rule
+             * @return the next definition stage
              */
             WithCreate withParameters(Object parameters);
         }
@@ -124,6 +132,8 @@ interface WithParameters {
         interface WithPolicyDefinitionId {
             /**
              * Specifies policyDefinitionId.
+             * @param policyDefinitionId The ID of the policy definition
+             * @return the next definition stage
              */
             WithCreate withPolicyDefinitionId(String policyDefinitionId);
         }
@@ -134,6 +144,8 @@ interface WithPolicyDefinitionId {
         interface WithScopeProperty {
             /**
              * Specifies scopeProperty.
+             * @param scopeProperty The scope for the policy assignment
+             * @return the next definition stage
              */
             WithCreate withScopeProperty(String scopeProperty);
         }
@@ -162,6 +174,8 @@ interface UpdateStages {
         interface WithDescription {
             /**
              * Specifies description.
+             * @param description This message will be part of response in case of policy violation
+             * @return the next update stage
              */
             Update withDescription(String description);
         }
@@ -172,6 +186,8 @@ interface WithDescription {
         interface WithDisplayName {
             /**
              * Specifies displayName.
+             * @param displayName The display name of the policy assignment
+             * @return the next update stage
              */
             Update withDisplayName(String displayName);
         }
@@ -182,6 +198,8 @@ interface WithDisplayName {
         interface WithParameters {
             /**
              * Specifies parameters.
+             * @param parameters Required if a parameter is used in policy rule
+             * @return the next update stage
              */
             Update withParameters(Object parameters);
         }
@@ -192,6 +210,8 @@ interface WithParameters {
         interface WithPolicyDefinitionId {
             /**
              * Specifies policyDefinitionId.
+             * @param policyDefinitionId The ID of the policy definition
+             * @return the next update stage
              */
             Update withPolicyDefinitionId(String policyDefinitionId);
         }
@@ -202,6 +222,8 @@ interface WithPolicyDefinitionId {
         interface WithScopeProperty {
             /**
              * Specifies scopeProperty.
+             * @param scopeProperty The scope for the policy assignment
+             * @return the next update stage
              */
             Update withScopeProperty(String scopeProperty);
         }

diff --git a/...01/src/main/java/com/microsoft/azure/management/policy/v2016_12_01/PolicyAssignments.java b/...01/src/main/java/com/microsoft/azure/management/policy/v2016_12_01/PolicyAssignments.java
@@ -56,7 +56,7 @@ public interface PolicyAssignments extends SupportsCreating<PolicyAssignment.Def
 
     /**
      * Deletes a policy assignment by ID.
-     * When providing a scope for the assigment, use '/subscriptions/{subscription-id}/' for subscriptions, '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}' for resource groups, and '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}/providers/{resource-provider-namespace}/{resource-type}/{resource-name}' for resources.
+     * When providing a scope for the assignment, use '/subscriptions/{subscription-id}/' for subscriptions, '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}' for resource groups, and '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}/providers/{resource-provider-namespace}/{resource-type}/{resource-name}' for resources.
      *
      * @param policyAssignmentId The ID of the policy assignment to delete. Use the format '/{scope}/providers/Microsoft.Authorization/policyAssignments/{policy-assignment-name}'.
      * @throws IllegalArgumentException thrown if parameters fail the validation
@@ -66,7 +66,7 @@ public interface PolicyAssignments extends SupportsCreating<PolicyAssignment.Def
 
     /**
      * Creates a policy assignment by ID.
-     * Policy assignments are inherited by child resources. For example, when you apply a policy to a resource group that policy is assigned to all resources in the group. When providing a scope for the assigment, use '/subscriptions/{subscription-id}/' for subscriptions, '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}' for resource groups, and '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}/providers/{resource-provider-namespace}/{resource-type}/{resource-name}' for resources.
+     * Policy assignments are inherited by child resources. For example, when you apply a policy to a resource group that policy is assigned to all resources in the group. When providing a scope for the assignment, use '/subscriptions/{subscription-id}/' for subscriptions, '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}' for resource groups, and '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}/providers/{resource-provider-namespace}/{resource-type}/{resource-name}' for resources.
      *
      * @param policyAssignmentId The ID of the policy assignment to create. Use the format '/{scope}/providers/Microsoft.Authorization/policyAssignments/{policy-assignment-name}'.
      * @param parameters Parameters for policy assignment.
@@ -77,7 +77,7 @@ public interface PolicyAssignments extends SupportsCreating<PolicyAssignment.Def
 
     /**
      * Gets a policy assignment by ID.
-     * When providing a scope for the assigment, use '/subscriptions/{subscription-id}/' for subscriptions, '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}' for resource groups, and '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}/providers/{resource-provider-namespace}/{resource-type}/{resource-name}' for resources.
+     * When providing a scope for the assignment, use '/subscriptions/{subscription-id}/' for subscriptions, '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}' for resource groups, and '/subscriptions/{subscription-id}/resourceGroups/{resource-group-name}/providers/{resource-provider-namespace}/{resource-type}/{resource-name}' for resources.
      *
      * @param policyAssignmentId The ID of the policy assignment to get. Use the format '/{scope}/providers/Microsoft.Authorization/policyAssignments/{policy-assignment-name}'.
      * @throws IllegalArgumentException thrown if parameters fail the validation

diff --git a/..._01/src/main/java/com/microsoft/azure/management/policy/v2016_12_01/PolicyDefinition.java b/..._01/src/main/java/com/microsoft/azure/management/policy/v2016_12_01/PolicyDefinition.java
@@ -89,6 +89,8 @@ interface Blank extends WithCreate {
         interface WithDescription {
             /**
              * Specifies description.
+             * @param description The policy definition description
+             * @return the next definition stage
              */
             WithCreate withDescription(String description);
         }
@@ -99,6 +101,8 @@ interface WithDescription {
         interface WithDisplayName {
             /**
              * Specifies displayName.
+             * @param displayName The display name of the policy definition
+             * @return the next definition stage
              */
             WithCreate withDisplayName(String displayName);
         }
@@ -109,6 +113,8 @@ interface WithDisplayName {
         interface WithMetadata {
             /**
              * Specifies metadata.
+             * @param metadata The policy definition metadata
+             * @return the next definition stage
              */
             WithCreate withMetadata(Object metadata);
         }
@@ -119,6 +125,8 @@ interface WithMetadata {
         interface WithMode {
             /**
              * Specifies mode.
+             * @param mode The policy definition mode. Possible values are NotSpecified, Indexed, and All. Possible values include: 'NotSpecified', 'Indexed', 'All'
+             * @return the next definition stage
              */
             WithCreate withMode(PolicyMode mode);
         }
@@ -129,6 +137,8 @@ interface WithMode {
         interface WithParameters {
             /**
              * Specifies parameters.
+             * @param parameters Required if a parameter is used in policy rule
+             * @return the next definition stage
              */
             WithCreate withParameters(Object parameters);
         }
@@ -139,6 +149,8 @@ interface WithParameters {
         interface WithPolicyRule {
             /**
              * Specifies policyRule.
+             * @param policyRule The policy rule
+             * @return the next definition stage
              */
             WithCreate withPolicyRule(Object policyRule);
         }
@@ -149,6 +161,8 @@ interface WithPolicyRule {
         interface WithPolicyType {
             /**
              * Specifies policyType.
+             * @param policyType The type of policy definition. Possible values are NotSpecified, BuiltIn, and Custom. Possible values include: 'NotSpecified', 'BuiltIn', 'Custom'
+             * @return the next definition stage
              */
             WithCreate withPolicyType(PolicyType policyType);
         }
@@ -177,6 +191,8 @@ interface UpdateStages {
         interface WithDescription {
             /**
              * Specifies description.
+             * @param description The policy definition description
+             * @return the next update stage
              */
             Update withDescription(String description);
         }
@@ -187,6 +203,8 @@ interface WithDescription {
         interface WithDisplayName {
             /**
              * Specifies displayName.
+             * @param displayName The display name of the policy definition
+             * @return the next update stage
              */
             Update withDisplayName(String displayName);
         }
@@ -197,6 +215,8 @@ interface WithDisplayName {
         interface WithMetadata {
             /**
              * Specifies metadata.
+             * @param metadata The policy definition metadata
+             * @return the next update stage
              */
             Update withMetadata(Object metadata);
         }
@@ -207,6 +227,8 @@ interface WithMetadata {
         interface WithMode {
             /**
              * Specifies mode.
+             * @param mode The policy definition mode. Possible values are NotSpecified, Indexed, and All. Possible values include: 'NotSpecified', 'Indexed', 'All'
+             * @return the next update stage
              */
             Update withMode(PolicyMode mode);
         }
@@ -217,6 +239,8 @@ interface WithMode {
         interface WithParameters {
             /**
              * Specifies parameters.
+             * @param parameters Required if a parameter is used in policy rule
+             * @return the next update stage
              */
             Update withParameters(Object parameters);
         }
@@ -227,6 +251,8 @@ interface WithParameters {
         interface WithPolicyRule {
             /**
              * Specifies policyRule.
+             * @param policyRule The policy rule
+             * @return the next update stage
              */
             Update withPolicyRule(Object policyRule);
         }
@@ -237,6 +263,8 @@ interface WithPolicyRule {
         interface WithPolicyType {
             /**
              * Specifies policyType.
+             * @param policyType The type of policy definition. Possible values are NotSpecified, BuiltIn, and Custom. Possible values include: 'NotSpecified', 'BuiltIn', 'Custom'
+             * @return the next update stage
              */
             Update withPolicyType(PolicyType policyType);
         }

diff --git a/...om/microsoft/azure/management/policy/v2016_12_01/implementation/PolicyAssignmentImpl.java b/...om/microsoft/azure/management/policy/v2016_12_01/implementation/PolicyAssignmentImpl.java
@@ -31,10 +31,10 @@ class PolicyAssignmentImpl extends CreatableUpdatableImpl<PolicyAssignment, Poli
         this.manager = manager;
         // Set resource name
         this.policyAssignmentName = inner.name();
-        // resource ancestor names
+        // set resource ancestor and positional variables
         this.policyAssignmentName = IdParsingUtils.getValueFromIdByName(inner.id(), "policyAssignments");
         this.scope = IdParsingUtils.getValueFromIdByPosition(inner.id(), 0);
-        //
+        // set other parameters for create and update
     }
 
     @Override