Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for CallAutomation to add version preview/2022-04-07-preview #2958

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

praveenkuttappan
Copy link

@praveenkuttappan praveenkuttappan commented Jul 14, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

fix #3025
fix #3026
fix #3027
fix azure-sdk/TestingForEngagementExperience#321
fix azure-sdk/TestingForEngagementExperience#325
fix azure-sdk/TestingForEngagementExperience#334

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jul 14, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.8) new version base version
communicationservicescallautomation.json 2022-04-07-preview(0aa4732) 2022-04-07-preview(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
package-2022-04-07-preview package-2022-04-07-preview(0aa4732) package-2022-04-07-preview(main)

The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.

Rule Message
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L364
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L427
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L474
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L512
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L600
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L663
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L904
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L941
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L19
⚠️ ParameterNamesConvention header parameter name 'Repeatability-Request-ID' should be kebab case.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L40
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L54
⚠️ ErrorResponse Error schema should define code and message properties as required.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L56
⚠️ Post201Response Using post for a create operation is discouraged.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L60
⚠️ ParameterNamesConvention header parameter name 'Repeatability-Request-ID' should be kebab case.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L96
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L110
⚠️ ErrorResponse Error schema should define code and message properties as required.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L112
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L131
⚠️ ParameterNamesConvention header parameter name 'Repeatability-Request-ID' should be kebab case.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L152
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L166
⚠️ ErrorResponse Error schema should define code and message properties as required.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L168
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L184
⚠️ ParameterNamesConvention header parameter name 'Repeatability-Request-ID' should be kebab case.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L205
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L219
⚠️ ErrorResponse Error schema should define code and message properties as required.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L221
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L244
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L256
⚠️ ErrorResponse Error schema should define code and message properties as required.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L258
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L275
⚠️ DeleteInOperationName 'DELETE' operation 'CallConnections_HangupCall' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L281
⚠️ OperationId OperationId for delete method should contain 'Delete'
Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L281
️️✔️[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@workflow-bot-test
Copy link

Hi, @praveenkuttappan! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app-test
    Copy link

    openapi-pipeline-app-test bot commented Jul 14, 2023

    Swagger Generation Artifacts

    ️🔄[ignore this check status; not blocking PR merge] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app-test
    Copy link

    openapi-pipeline-app-test bot commented Jul 14, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger CallAutomation https://apiviewstagingtest.com/Assemblies/Review/224ad4b2fcd84615af973cc42c3c423a?revisionId=43478ad343a342939c1c59742997404e

    Copy link

    openapi-dev-app-company2 bot commented Jan 24, 2024

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ This is the public specs repo main branch which is not intended for iterative development.
      You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
      If this is what you intend, add PublishToCustomers label to your PR.
      Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
    • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

    @praveenkuttappan
    Copy link
    Author

    /azp run

    Copy link

    There was an error handling pipeline event 5aabf1a8-f956-42d8-8fd1-b78cf7f984bf. The command could not be run.

    @praveenkuttappan
    Copy link
    Author

    /azp run

    Copy link

    Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

    @praveenkuttappan
    Copy link
    Author

    /azp run

    Copy link

    Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

    …2022-04-07-preview/communicationservicescallautomation.json
    This was referenced Oct 23, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment