-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add restlerConfig for 2020-06 version #2639
Conversation
Hi, @ruowan Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger pipeline started successfully, please wait for status update in this comment. |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.7)] | new version | base version |
---|---|---|
restlerConfig | 2022-05-01(5dea1ff) | 2022-05-01(main) |
appconfiguration.json | 2020-06-01(5dea1ff) | 2020-06-01(main) |
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/5dea1ff66c0632c89b44451002e81d646e039251/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/stable/2022-05-01/restlerConfig", "old":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/main/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/stable/2022-05-01/restlerConfig", "details":"Command failed: node /mnt/vss/_work/_tasks/AzureApiValidationTest_1a18ed4f-f3bf-4f34-9fed-13cb57bd2410/0.0.248/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js /tmp/readme.oad.old.md --v2 --tag=oad-default-tag --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: File 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/stable/2022-05-01/restlerConfig/dict.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n(node:7596) UnhandledPromiseRejectionWarning: Error: File 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/stable/2022-05-01/restlerConfig/dict.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n at LoadLiterateSwagger (/home/cloudt" |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2020-06-01 | package-2020-06-01(5dea1ff) | package-2020-06-01(main) |
The following errors/warnings exist before current PR submission:
️️✔️
~[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
️❌
~[Staging] TrafficValidation: 0 Errors, 0 Warnings failed [Detail]
️🔄
CredScan inProgress [Detail]
️⌛
PoliCheck pending [Detail]
️❌
Avocado: 4 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
UNREFERENCED_JSON_FILE |
The swagger JSON file is not referenced from the readme file. readme: specification/appconfiguration/resource-manager/readme.md json: stable/2020-06-01/restler/dict.json |
UNREFERENCED_JSON_FILE |
The swagger JSON file is not referenced from the readme file. readme: specification/appconfiguration/resource-manager/readme.md json: stable/2020-06-01/restler/engine_settings.json |
UNREFERENCED_JSON_FILE |
The swagger JSON file is not referenced from the readme file. readme: specification/appconfiguration/resource-manager/readme.md json: stable/2022-05-01/restler/dict.json |
UNREFERENCED_JSON_FILE |
The swagger JSON file is not referenced from the readme file. readme: specification/appconfiguration/resource-manager/readme.md json: stable/2022-05-01/restler/engine_settings.json |
️❌
ModelValidation: 4 Errors, 0 Warnings failed [Detail]
️❌
SemanticValidation: 56 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️❌
~[Staging] PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Code style issues found path: stable/2022-05-01/restler/dict.json |
️❌
~[Staging] SpellCheck: 18 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Unknown word (restler), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L2:4 |
HowToFix |
Unknown word (fuzzable), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L2:12 |
HowToFix |
Unknown word (restler), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L3:4 |
HowToFix |
Unknown word (fuzzable), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L3:12 |
HowToFix |
Unknown word (restler), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L4:4 |
HowToFix |
Unknown word (fuzzable), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L4:12 |
HowToFix |
Unknown word (restler), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L5:4 |
HowToFix |
Unknown word (fuzzable), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L5:12 |
HowToFix |
Unknown word (configstor), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L27:25 |
HowToFix |
Unknown word (privateend), please fix the error or add words to ./custom-words.txt path: stable/2020-06-01/restler/dict.json#L29:39 |
HowToFix |
Unknown word (restler), please fix the error or add words to ./custom-words.txt path: stable/2022-05-01/restler/dict.json#L2:4 |
HowToFix |
Unknown word (fuzzable), please fix the error or add words to ./custom-words.txt path: stable/2022-05-01/restler/dict.json#L2:12 |
HowToFix |
Unknown word (restler), please fix the error or add words to ./custom-words.txt path: stable/2022-05-01/restler/dict.json#L3:4 |
HowToFix |
Unknown word (fuzzable), please fix the error or add words to ./custom-words.txt path: stable/2022-05-01/restler/dict.json#L3:12 |
HowToFix |
Unknown word (restler), please fix the error or add words to ./custom-words.txt path: stable/2022-05-01/restler/dict.json#L4:4 |
HowToFix |
Unknown word (fuzzable), please fix the error or add words to ./custom-words.txt path: stable/2022-05-01/restler/dict.json#L4:12 |
HowToFix |
Unknown word (restler), please fix the error or add words to ./custom-words.txt path: stable/2022-05-01/restler/dict.json#L5:4 |
HowToFix |
Unknown word (fuzzable), please fix the error or add words to ./custom-words.txt path: stable/2022-05-01/restler/dict.json#L5:12 |
️⚠️
[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/test-repo-billy/azure-rest-api-specs/blob/5dea1ff66c0632c89b44451002e81d646e039251/specification/appconfiguration/resource-manager/readme.md#tag-package-2020-06-01">appconfiguration/resource-manager/readme.md#package-2020-06-01
Rule | Message |
---|---|
"readme":"appconfiguration/resource-manager/readme.md", "tag":"package-2020-06-01", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
Swagger pipeline started successfully, please wait for status update in this comment. |
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
Swagger Generation Artifacts
|
Generated ApiView
|
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.