Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestUnifiedPipeline] Add Private link and Private link association APIs #1881

Closed

Conversation

zhenglaizhang
Copy link

Mirror from https://github.com/Azure/azure-rest-api-specs/pull/11364

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Oct 27, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] LintDiff succeeded [Detail]
Validation passes for LintDiff.
️❌~[Staging] Avocado: 6 Errors, 0 Warnings failed [Detail] [Expand]
Rule Message
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/resources/resource-manager/readme.md
json: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2020-05-01/examples/createPrivateLink.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2020-05-01/examples/deletePrivateLink.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2020-05-01/examples/getPrivateLink.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2020-05-01/examples/getPrivateLinkAssociation.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/resources/resource-manager/readme.md
json: Microsoft.Authorization/stable/2020-05-01/privateLinkAssociation.json
️❌~[Staging] ModelValidation: 7 Errors, 0 Warnings failed [Detail] [Expand]
Rule Message
ERROR_IN_PREPARING_REQUEST pathTemplate: /subscriptions/{subscriptionId}/resourceGroups/{sourceResourceGroupName}/providers/Microsoft.Authorization/resourceManagementPrivateLinks/{resourceManagementPrivateLinksName} contains the path parameter sourceResourceGroupName however, it is not present in [object Object] - { "subscriptionId": "{subscriptionId}", "resourceGroupName": "{resourceGroupName}", "resourceManagementPrivateLinksName": "myPrivateLink" }.The value of the path parameter can either be a "string" of the form { sourceResourceGroupName: "some sample value" } or it can be an "object" of the form { "sourceResourceGroupName": { value: "some sample value", skipUrlEncoding: true } }.
Url: stable/2020-05-01/examples/createPrivateLink.json#L1
RESPONSE_STATUS_CODE_NOT_IN_SPEC Response statusCode "200" for operation "ResourceManagementPrivateLinks_Put" is provided in exampleResponseValue, however it is not present in the swagger spec.
ERROR_IN_PREPARING_REQUEST pathTemplate: /subscriptions/{subscriptionId}/resourceGroups/{sourceResourceGroupName}/providers/Microsoft.Authorization/resourceManagementPrivateLinks/{resourceManagementPrivateLinksName} contains the path parameter sourceResourceGroupName however, it is not present in [object Object] - { "subscriptionId": "{subscriptionId}", "resourceGroupName": "{resourceGroupName}", "resourceManagementPrivateLinksName": "myPrivateLink" }.The value of the path parameter can either be a "string" of the form { sourceResourceGroupName: "some sample value" } or it can be an "object" of the form { "sourceResourceGroupName": { value: "some sample value", skipUrlEncoding: true } }.
Url: stable/2020-05-01/examples/deletePrivateLink.json#L1
RESPONSE_STATUS_CODE_NOT_IN_SPEC Response statusCode "200" for operation "ResourceManagementPrivateLinks_Delete" is provided in exampleResponseValue, however it is not present in the swagger spec.
ERROR_IN_PREPARING_REQUEST pathTemplate: /subscriptions/{subscriptionId}/resourceGroups/{sourceResourceGroupName}/providers/Microsoft.Authorization/resourceManagementPrivateLinks/{resourceManagementPrivateLinksName} contains the path parameter sourceResourceGroupName however, it is not present in [object Object] - { "subscriptionId": "{subscriptionId}", "resourceGroupName": "{resourceGroupName}", "resourceManagementPrivateLinksName": "myPrivateLink" }.The value of the path parameter can either be a "string" of the form { sourceResourceGroupName: "some sample value" } or it can be an "object" of the form { "sourceResourceGroupName": { value: "some sample value", skipUrlEncoding: true } }.
Url: stable/2020-05-01/examples/getPrivateLink.json#L1
RESPONSE_STATUS_CODE_NOT_IN_SPEC Response statusCode "200" for operation "ResourceManagementPrivateLinks_Get" is provided in exampleResponseValue, however it is not present in the swagger spec.
RESPONSE_STATUS_CODE_NOT_IN_SPEC Response statusCode "200" for operation "PrivateLinkAssociations_Get" is provided in exampleResponseValue, however it is not present in the swagger spec.
️❌~[Staging] SemanticValidation: 10 Errors, 0 Warnings failed [Detail] [Expand]
Rule Message
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
JsonUrl: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json#L155
OBJECT_PROPERTIES_MINIMUM Too few properties defined (0), minimum 1
JsonUrl: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json
NOT_PASSED Data matches schema from 'not'
JsonUrl: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json
OBJECT_PROPERTIES_MINIMUM Too few properties defined (0), minimum 1
JsonUrl: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json
NOT_PASSED Data matches schema from 'not'
JsonUrl: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json
OBJECT_PROPERTIES_MINIMUM Too few properties defined (0), minimum 1
JsonUrl: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json
NOT_PASSED Data matches schema from 'not'
JsonUrl: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: $ref
JsonUrl: Microsoft.Authorization/stable/2020-05-01/PrivateLinks.json#L67
OBJECT_PROPERTIES_MINIMUM Too few properties defined (0), minimum 1
JsonUrl: Microsoft.Authorization/stable/2020-05-01/privateLinkAssociation.json
NOT_PASSED Data matches schema from 'not'
JsonUrl: Microsoft.Authorization/stable/2020-05-01/privateLinkAssociation.json
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Oct 27, 2020

Swagger Generation Artifacts

️❌~[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail] [Expand]
Rule Message
RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=170385&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
"detail":"Run.ps1 failed with exit code 1 "
Posted by Swagger Pipeline | How to fix these errors?

openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-js that referenced this pull request Oct 27, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-js that referenced this pull request Oct 27, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-js that referenced this pull request Oct 27, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-js that referenced this pull request Oct 27, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-net that referenced this pull request Oct 27, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
openapi-sdkautomation-test bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 2e861dbceaa594eb3335c902960e524f24911d2c into e21b960c504994bb94e16f96bf72d6da6ac06d25
@azure-sdk azure-sdk force-pushed the master branch 10 times, most recently from 65a8880 to 95a8b02 Compare November 6, 2020 15:02
@azure-sdk azure-sdk force-pushed the master branch 12 times, most recently from 03a3f67 to 61004f9 Compare November 15, 2020 03:01
@azure-sdk azure-sdk force-pushed the master branch 7 times, most recently from 60b23e4 to ded7843 Compare November 19, 2020 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant