Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c.vm.box configuration incorrectly set for bento/hardenedbsd-11 in generated Vagrantfile #349

Closed
nusenu opened this issue Mar 27, 2018 · 3 comments
Assignees

Comments

@nusenu
Copy link

nusenu commented Mar 27, 2018

kitchen-vagrant creates the following box line in the Vagrant file when using "- name: hardenedbsd-11":

c.vm.box = "hardenedbsd-11"

but it should be:

c.vm.box = "bento/hardenedbsd-11"

The same problem probably occurs once we add OpenBSD to bento.

%w{centos debian fedora opensuse ubuntu oracle freebsd}.each do |name|

REF:
nusenu/ansible-relayor/issues/155

@cheeseplus
Copy link
Contributor

kitchen-vagrant will need to be updated to "know" about any new distros and then this will go away.

@nusenu
Copy link
Author

nusenu commented Apr 22, 2018 via email

@cheeseplus
Copy link
Contributor

cheeseplus commented Apr 23, 2018

Two places need the change:

the code itself that needs updating
https://github.com/test-kitchen/kitchen-vagrant/blob/master/lib/kitchen/driver/vagrant.rb#L237

the unit test (which you've found)

%w{centos debian fedora opensuse ubuntu oracle freebsd}.each do |name|

Both need to be updated for this to work but it should be an easy PR.

cheeseplus pushed a commit that referenced this issue Apr 23, 2018
@cheeseplus cheeseplus self-assigned this Apr 23, 2018
cheeseplus pushed a commit that referenced this issue Apr 24, 2018
Fixing #349 - allow bento/hardenedbsd
stissot pushed a commit to Ecodev/kitchen-vagrant that referenced this issue Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants