ccstruct: Fix Leptonica data type

[stweil]

L_Bmf works for C++ code, but the common form is L_BMF, so use that.

Signed-off-by: Stefan Weil [email protected]

[stweil]

@theraysmith, maybe you a referring to the Leptonica style guide. I think it's a style guide for the Leptonica code, not for code using Leptonica (like Tesseract).

[amitdo]

https://github.com/DanBloomberg/leptonica/blob/master/style-guide.txt

(c) Use typedefs for structs like Pix; e.g.,
function(PIX *pixs)
Do not do this (omitting the 'struct' keyword); it is valid C++,
but not C:
function(Pix *pixs)

https://github.com/DanBloomberg/leptonica/blob/150c8d0051/src/bmf.h#L45

Since Tesseract code is based on C++, we should use a C++ style guide.
https://google.github.io/styleguide/cppguide.html#Type_Names

[theraysmith]

The newer tesseract code uses the Google C++ style guide: https://google.github.io/styleguide/cppguide.html and we have an internal tool that reformats your code for you, hence the occasional commit with the formatting changes. Anyway style guide has nothing to do with using the correct name for Leptonica classes, and Dan says we should be using Pix in C++, not PIX.

…

On Fri, Apr 28, 2017 at 6:12 AM, Amit D. ***@***.***> wrote: https://github.com/DanBloomberg/leptonica/blob/master/style-guide.txt (c) Use typedefs for structs like Pix; e.g., function(PIX *pixs) Do not do this (omitting the 'struct' keyword); it is valid C++, but not C: function(Pix *pixs) https://github.com/DanBloomberg/leptonica/blob/ 150c8d005132c85dac0c6388b8408a485f2b65ac/src/bmf.h#L45 Since Tesseract code is based on C++, we should use a C++ style guide. https://google.github.io/styleguide/cppguide.html#Type_Names — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#848 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AL056YU7BU-qAN6kjGkgqqZgKgfYw9tCks5r0eWwgaJpZM4NJwso> .

-- Ray.

[stweil]

I must admit that I'm confused now. If Dan prefers Pix, I'd change the Leptonica to allow Pix for C as well (and maintain PIX for backward compatibility, maybe with a deprecation attribute).

Ray, the code in opencl/ needs much formatting. Could you do this with your internal tool (or make it public, then I could assist)?

[amitdo]

Ray,
According to some of your commit messages you use clang-tidy.

What about adding a .clang-format file to the public repo?
https://clang.llvm.org/docs/ClangFormatStyleOptions.html

[stweil]

Ray reverted this pull request with commit 7a116ce. My new pull request #855 fixes the remaining exceptions which currently don't use the preferred struct name.

Ray, thank you for formatting opencl/. I noticed that some issues like There is never a space between the parentheses and the parameters were not fixed (see also issue #854).