CMake - Set minimum Leptonica version to 1.74.0 #608
Conversation
|
In
to
? |
|
@amitdo: |
|
This is how it is tagged in the github repo. In the Leptonica website it is '1.74'. |
|
Well allheaders.h defines only LIBLEPT_MAJOR_VERSION (1) and LIBLEPT_MINOR_VERSION (74), so I see no reason to change... |
|
I did it after the So I thought it should be 1.74.0 in CMake too. |
|
The |
|
It's a switch to semver also. 1.74.0 tag in git and version numbers in code/build tools. |
|
For cmake |
|
At least for cmake 3.6.2 only 1.74 but not 1.74.0 works. Tested on Raspbian. |
|
I am not near a computer to check. Does Tesseract 3.04 build against
Leptonica 1.74? It is this version number stuff causing trouble?
On Dec 26, 2016 6:31 AM, "Stefan Weil" <[email protected]> wrote:
At least for cmake 3.6.2 only 1.74 but not 1.74.0 works. Tested on Raspbian.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#608 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEu2phQlhZsUnHI3zUF9VY1LXj19gYi-ks5rL8-jgaJpZM4LVW_Z>
.
|
|
I just ran a test with cmake 3.7.1-1 on Debian GNU Linux. It also works only with 1.74, but not with 1.74.0. |
|
Seems like we have a problem with the 1.74.0 version numbering. What do
you suggest that we do here? New github release? Replacement? Nothing?
…On Mon, Dec 26, 2016 at 2:10 PM, Stefan Weil ***@***.***> wrote:
I just ran a test with cmake 3.7.1-1 on Debian GNU Linux. It also works
only with 1.74, but not with 1.74.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#608 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP6mLNTIpQ9_c7fCyh6OFkdZidkx24NCks5rMDtvgaJpZM4LVW_Z>
.
|
|
I am in the snowy hinterlands, won't be able to advise until new year. So
far I can't tell if this is important or not. If I had to guess, we are
probably fine, especially if the autoconf build on Tesseract had no issues.
(I just want to keep the chaos level low in the world of Debian packages)
On Dec 28, 2016 9:00 AM, "Dan Bloomberg" <[email protected]> wrote:
Seems like we have a problem with the 1.74.0 version numbering. What do
you suggest that we do here? New github release? Replacement? Nothing?
On Mon, Dec 26, 2016 at 2:10 PM, Stefan Weil ***@***.***> wrote:
I just ran a test with cmake 3.7.1-1 on Debian GNU Linux. It also works
only with 1.74, but not with 1.74.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#608#
issuecomment-269245065>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP6mLNTIpQ9_
c7fCyh6OFkdZidkx24NCks5rMDtvgaJpZM4LVW_Z>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#608 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEu2prjMBcM6137QaP9GwOgubdDmKBDUks5rMpW7gaJpZM4LVW_Z>
.
|
|
Dan, the issue (if any) is probably somewhere in autotools config on lept side. No need to rename git tag, it's fine. In case of any critical changes, you could remove tag and add it again, or just make 1.74.1 release with fixes. |
|
The problem is that Leptonica's |
|
Yes, I think this is the reason why 1.74.0 did not work for me. |
|
Seems like I should make a new github release for leptonica, with the correct version
number in configure.ac. If you agree, should I replace 1.74.0 or make
1.74.1?
…-- Dan
On Sat, Dec 31, 2016 at 1:51 PM, Stefan Weil ***@***.***> wrote:
Yes, I think this is the reason why 1.74.0 did not work for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#608 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP6mLB1I0zUtfSfCWjkMVAISrwSDgVG2ks5rNs5zgaJpZM4LVW_Z>
.
|
|
I suggest using 1.74.1. Fixes are needed for |
|
... and |
|
At this point, I don't mind sticking with 1.74 for now as we've already compensated in the necessary places. My Gentoo release ended up being 1.74 as this matched the tarball and the tarball's subdirectory. But if you want to push a new 1.74.1 release out to make sure we get it right while it's still fresh in our minds, that's cool. |
|
@DanBloomberg: if you decide to implement version format "1.74.1" do not forget to implement it into allheaders.h as LIBLEPT_MAJOR_VERSION (1), LIBLEPT_MINOR_VERSION (74) and LIBLEPT_MICRO_VERSION (1)... |
|
|
|
Or better LIBLEPT_PATCH_VERSION as in semver (major.minor.patch). |
|
I was thinking of RELEASE, but I can go with PATCH.
…On Sun, Jan 1, 2017 at 8:49 AM, Egor Pugin ***@***.***> wrote:
Or better LIBLEPT_PATCH_VERSION as in semver (major.minor.patch).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#608 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP6mLEGrqUyXl5dJF8dqs5zpJFRjyylwks5rN9kwgaJpZM4LVW_Z>
.
|
|
I've put up on github the leptonica 1.74.1 release.
In theory, it solves all the existing issues with builds. In practice,
we'll see ...
It's also up as a configure/make tarball on leptonica.org. (The difference
between the two is just running the autobuild script on the github release,
which requires autotools.)
… I was thinking of RELEASE, but I can go with PATCH.
On Sun, Jan 1, 2017 at 8:49 AM, Egor Pugin ***@***.***>
wrote:
> Or better LIBLEPT_PATCH_VERSION as in semver (major.minor.patch).
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#608 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AP6mLEGrqUyXl5dJF8dqs5zpJFRjyylwks5rN9kwgaJpZM4LVW_Z>
> .
>
|
No description provided.