Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more cube related code #586

Merged
merged 2 commits into from
Dec 16, 2016
Merged

Remove more cube related code #586

merged 2 commits into from
Dec 16, 2016

Conversation

stweil
Copy link
Member

@stweil stweil commented Dec 15, 2016

No description provided.

@zdenop
Copy link
Contributor

zdenop commented Dec 15, 2016

IMO support for VS2010 should be dropped in 4.00 because of c++11...

@stweil
Copy link
Member Author

stweil commented Dec 15, 2016

That would simplify things.

@amitdo
Copy link
Collaborator

amitdo commented Dec 15, 2016

Don't remove the 'port' dir.

@egorpugin
Copy link
Contributor

That dir (port) should be just reorganized. VS solutions could be removed because we have cmake.

By the way, did you decide how to version 4 branch? 4.00 or 4.0.0 ?

@stweil
Copy link
Member Author

stweil commented Dec 16, 2016

4.0.0 could be a start for semantic versioning (like it is used by many other projects).

@egorpugin
Copy link
Contributor

egorpugin commented Dec 16, 2016

That's why I'm asking. My vote is for 4.0.0.

@zdenop
Copy link
Contributor

zdenop commented Dec 16, 2016

There is 4.00.00alpha and 4.00.00dev version info. If there is change request - create PR and ask Ray for merge...

@zdenop
Copy link
Contributor

zdenop commented Dec 16, 2016

@stweil: will you update this PR according comments (VS removal, port reorganized)?

@egorpugin
Copy link
Contributor

egorpugin commented Dec 16, 2016

If there is change request - create PR and ask Ray for merge...

Sure. Will do it if there are no serious objections. Also following tags must be also named as 4.0.0-smth.
https://github.com/tesseract-ocr/tesseract/releases

@stweil
Copy link
Member Author

stweil commented Dec 16, 2016

@zdenop, I removed the VS related commit from this PR now. Removing VS and moving port can be handled in a new PR.

@zdenop zdenop merged commit e2e0b90 into tesseract-ocr:master Dec 16, 2016
@zdenop
Copy link
Contributor

zdenop commented Dec 16, 2016

thanks

@stweil stweil deleted the cube branch December 16, 2016 07:24
@egorpugin
Copy link
Contributor

@zdenop
By the way, maybe you'd like to reorganize sources also?

  1. move all sources to src dir.
  2. (optional) add include dir with all public stuff - headers.

@egorpugin
Copy link
Contributor

I can do this, but someone should fix autotools after the changes.

@zdenop
Copy link
Contributor

zdenop commented Dec 16, 2016

@egorpugin : reorganization of sources should be discussed with Ray...

@egorpugin
Copy link
Contributor

Ok, I'll ask him a bit later when fixing version numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants